Fix setting filters without $store value #56304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
added
review
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
lizozom
reviewed
Jan 30, 2020
Setting the store is not longer temporary
streamich
reviewed
Jan 30, 2020
lizozom
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Tested and makes sense.
Merging this means that #56213 can be reverted! @FrankHassanabad
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Dosant
commented
Jan 31, 2020
| ? esFilters.FilterStateStore.GLOBAL_STATE | ||
| : esFilters.FilterStateStore.APP_STATE; | ||
|
|
||
| FilterManager.setFiltersStore(newFilters, store); |
There was a problem hiding this comment.
note: FilterManager.setFiltersStore() sets new store only if filter is missing it
There was a problem hiding this comment.
Agree that we should rename it. But I think we better do it in separate pr to keep this one scoped to filter_manager and just the bugfix which we backport to 7.6
Dosant
added
bug
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Jan 31, 2020
Follow up on: elastic#56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 31, 2020
* master: (53 commits) Fix setting filters without $store value (elastic#56304) kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) [Reporting] New Platform: moves most of our libs/constants and utils to np shims (elastic#55935) [reporting] remove a legacy cross-plugin import (elastic#56354) [DOCS] Updates example in Timelion doc (elastic#56444) [APM] Service map center button (elastic#56434) [skip-ci] Add example for migrating pre-handlers (elastic#56080) [ML] Fix Data Visualizer responsive layout (elastic#56372) Add missing docker settings (elastic#56411) [Endpoint] Add Endpoint Details route (elastic#55746) chore(NA): delete data/optimize with kbn clean (elastic#55890) System index templates can't be edited (elastic#55229) Sync badge (elastic#55113) Only fire appState changes when there is a change (elastic#56183) Import appropriate files to setup plugin system at the correct time (elastic#55956) [Monitoring] Change all configs to `monitoring.*` (elastic#56215) [ML] conditional rison encoding for query params (elastic#56380) Move tsvb server to new platform (elastic#55310) exclude tutorial resources from code ownership (elastic#55987) [Watcher] Follow up on flaky functional test (elastic#56384) ...
Dosant
added a commit
that referenced
this pull request
Jan 31, 2020
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Jan 31, 2020
Follow up on: elastic#56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 31, 2020
…56356 * '7.x' of github.com:elastic/kibana: (23 commits) Fix setting filters without $store value (elastic#56304) (elastic#56475) [ML] Fix Data Visualizer responsive layout (elastic#56372) (elastic#56472) [ML] conditional rison encoding for query params (elastic#56380) (elastic#56469) kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) (elastic#56471) [APM] Fit service map to container (elastic#56336) (elastic#56463) Add animation to service map layout (elastic#56042) (elastic#56460) chore(NA): delete data/optimize with kbn clean (elastic#55890) (elastic#56422) [APM] Storybook support (elastic#54970) (elastic#56445) [DOCS] Updates example in Timelion doc (elastic#56444) (elastic#56454) [Logs UI] Fix Check for New Data button on empty indices screen (elastic#56239) (elastic#56320) [DOCS] Adds breaking changes for 7.6 (elastic#56437) [Monitoring] Change all configs to `monitoring.*` (elastic#56215) (elastic#56421) [skip-ci] Add example for migrating pre-handlers (elastic#56080) (elastic#56436) [7.x] System index templates can't be edited (elastic#55229) (elastic#56417) Add missing docker settings (elastic#56411) [Uptime] Use dynamic index pattern in Uptime (elastic#55446) (elastic#56386) fix edit rule for detections (elastic#56333) (elastic#56405) [Filter Bar] Remove flickering when opening filter bar popover (elastic#56222) (elastic#56385) [ILM] Index Lifecycle Policies show wrong unit in Kibana UI (elastic#55228) (elastic#55757) Move tsvb server to new platform (elastic#55310) (elastic#56394) ...
Dosant
added a commit
that referenced
this pull request
Jan 31, 2020
jfsiii
pushed a commit
to jfsiii/kibana
that referenced
this pull request
Feb 4, 2020
Follow up on: elastic#56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on: #56213
AddFiltersmethod had logic which ensured that$storeexists in filter object, butsetFilterswas missing that.I am not sure, if there is a way to reproduce the bug from the UI, except already fixed #56213. So the bug's impact is unknown.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers