[SIEM][Detection Engine] critical blocker with the UI crashing #56213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankHassanabad
added
v8.0.0
v7.7.0
v7.6.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
spong
approved these changes
Jan 28, 2020
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security·ts.dashboard feature controls dashboard security global dashboard & embeddable all privileges allow saving via the saved query management component popover with no query loadedStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
This was referenced Jan 28, 2020
7 tasks
Dosant
added a commit
that referenced
this pull request
Jan 31, 2020
Follow up on: #56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Jan 31, 2020
Follow up on: elastic#56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.
Dosant
added a commit
that referenced
this pull request
Jan 31, 2020
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Jan 31, 2020
Follow up on: elastic#56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.
Dosant
added a commit
that referenced
this pull request
Jan 31, 2020
jfsiii
pushed a commit
to jfsiii/kibana
that referenced
this pull request
Feb 4, 2020
Follow up on: elastic#56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you have filters which do not have a $app and state it blows up which isn't what we want to happen. This adds a function which default adds it on the UI if it does not exist
Test:
Post query with everything
Then visit in the details section of the UI and it should no longer blow up.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately