Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pinned ES snapshot #53645

Closed
wants to merge 9 commits into from
Closed

Revert pinned ES snapshot #53645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c5894d3
Revert pinned ES snapshot
jbudz Dec 19, 2019
1375286
Temporarily create ES snapshot from source
jbudz Dec 19, 2019
b8454f4
Merge branch 'master' into issues/pinned-es-snapshot
jbudz Dec 19, 2019
788027e
Merge branch 'master' into issues/pinned-es-snapshot
jbudz Dec 20, 2019
cd45d6f
Revert "Temporarily create ES snapshot from source"
jbudz Dec 20, 2019
857dc5e
Enable field data for _id in .kibana
jbudz Dec 20, 2019
0ac7f64
pass setings through migration context
jbudz Dec 20, 2019
2a02f46
lint
jbudz Dec 20, 2019
20fcf5b
Merge remote-tracking branch 'upstream/master' into issues/pinned-es-…
Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/core/server/saved_objects/migrations/core/elastic_index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export interface FullIndexInfo {
exists: boolean;
indexName: string;
mappings: IndexMapping;
settings: { [name: string]: any };
}

/**
Expand All @@ -51,6 +52,9 @@ export async function fetchInfo(callCluster: CallCluster, index: string): Promis
aliases: {},
exists: false,
indexName: index,
settings: {
'indices.id_field_data.enabled': true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what this would do here. In addition, this is a cluster-level setting, so this won't work. I believe the solution here is to remove any sort/aggregating we have on _id

},
mappings: { dynamic: 'strict', properties: {} },
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/core/server/saved_objects/migrations/core/migration_context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ export async function migrationContext(opts: MigrationOpts): Promise<Context> {
const alias = opts.index;
const source = createSourceContext(await fetchInfo(callCluster, alias), alias);
const dest = createDestContext(source, alias, opts.mappingProperties);

return {
callCluster,
alias,
Expand Down Expand Up @@ -115,6 +114,7 @@ function createDestContext(
aliases: {},
exists: false,
indexName: nextIndexName(source.indexName, alias),
settings: source.settings,
mappings: {
...activeMappings,
properties: {
Expand Down