-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert pinned ES snapshot #53645
Revert pinned ES snapshot #53645
Conversation
Elasticsearch was pinned to an older version due to a migrations failure. Root cause was determined to be upstream and tracked at elastic/elasticsearch#50248. Now that a fix is merged we can see where the most recent snapshot leaves us.
Until new artifacts are built we need to build from source to test the mappings fix. This is for testing the most recent fixes and should be reverted before merging.
retest |
elastic/elasticsearch#49166 is next - short term we need to set fielddata to true. |
In 8.0 field data is defaulted to false in Elasticsearch. We make use if this in several areas. The setting change is to reduce memory pressure. The Kibana index typically isn't very large so this is not expected to have a large impact.
Migrations are running on hash changes of mappings it looks like..need to push settings changes |
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
merge conflict between base and head |
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
@@ -51,6 +52,9 @@ export async function fetchInfo(callCluster: CallCluster, index: string): Promis | |||
aliases: {}, | |||
exists: false, | |||
indexName: index, | |||
settings: { | |||
'indices.id_field_data.enabled': true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what this would do here. In addition, this is a cluster-level setting, so this won't work. I believe the solution here is to remove any sort/aggregating we have on _id
I have highlighted the path forward here: #52517 (comment). Since we're automating the snapshots, we no longer need this PR to unpin the snapshot once the sorting on |
This can be closed. |
Elasticsearch was pinned to an older version due to a migrations
failure. Root cause was determined to be upstream and tracked at
elastic/elasticsearch#50248. Now that a fix is merged we can see where
the most recent snapshot leaves us.