Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Removing context API #52953

Merged
merged 1 commit into from
Dec 13, 2019
Merged

[ML] Removing context API #52953

merged 1 commit into from
Dec 13, 2019

Conversation

jgowdyelastic
Copy link
Member

Changes for compatibility with NP changes in #50231

Relates to #52948

@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.6.0 labels Dec 12, 2019
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner December 12, 2019 20:57
@jgowdyelastic jgowdyelastic self-assigned this Dec 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

peteharverson
peteharverson approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 6ba805d into elastic:master Dec 13, 2019
@jgowdyelastic jgowdyelastic deleted the remove-context-from-plugin branch December 13, 2019 10:33
@jgowdyelastic jgowdyelastic mentioned this pull request Dec 13, 2019
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Dec 13, 2019
@jgowdyelastic
[ML] Removing context API (elastic#52953)
ce496b3
jgowdyelastic added a commit that referenced this pull request Dec 13, 2019
@jgowdyelastic
[ML] Removing context API (#52953) (#53001)
d009b01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra Awaiting requested review from walterra

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:NP Migration :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgowdyelastic @elasticmachine @alvarezmelissa87 @peteharverson