-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getStartServices API #50231
Merged
Merged
Add getStartServices API #50231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
|
joshdover
force-pushed
the
np/bind-services
branch
from
November 22, 2019 23:35
4eba533
to
b6c0192
Compare
💔 Build Failed
|
2 tasks
joshdover
force-pushed
the
np/bind-services
branch
from
November 25, 2019 17:38
b6c0192
to
e2a7120
Compare
💔 Build Failed
|
joshdover
force-pushed
the
np/bind-services
branch
from
November 26, 2019 21:34
e2a7120
to
8920997
Compare
💔 Build Failed
|
joshdover
force-pushed
the
np/bind-services
branch
from
November 27, 2019 20:04
8920997
to
589631e
Compare
💔 Build Failed
|
joshdover
force-pushed
the
np/bind-services
branch
from
December 2, 2019 20:50
589631e
to
bfb2ca9
Compare
💚 Build Succeeded
|
joshdover
force-pushed
the
np/bind-services
branch
2 times, most recently
from
December 4, 2019 22:47
f77672c
to
a63355a
Compare
💚 Build Succeeded
|
💚 Build Succeeded
|
joshdover
added
Feature:New Platform
release_note:plugin_api_changes
Contains a Plugin API changes section for the breaking plugin API changes section.
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.6.0
labels
Dec 5, 2019
Pinging @elastic/kibana-platform (Team:Platform) |
8 tasks
joshdover
force-pushed
the
np/bind-services
branch
from
December 6, 2019 21:50
8b69001
to
2f81b9c
Compare
pgayvallet
reviewed
Dec 7, 2019
joshdover
force-pushed
the
np/bind-services
branch
from
December 9, 2019 17:59
2f81b9c
to
3b255d2
Compare
joshdover
force-pushed
the
np/bind-services
branch
3 times, most recently
from
December 9, 2019 22:49
7594850
to
cabb09f
Compare
pgayvallet
approved these changes
Dec 10, 2019
joshdover
force-pushed
the
np/bind-services
branch
from
December 10, 2019 15:59
cabb09f
to
d16a67f
Compare
joshdover
force-pushed
the
np/bind-services
branch
from
December 11, 2019 20:19
d16a67f
to
76883b3
Compare
This was referenced Dec 12, 2019
joshdover
added a commit
that referenced
this pull request
Dec 12, 2019
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
7 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:New Platform
release_note:plugin_api_changes
Contains a Plugin API changes section for the breaking plugin API changes section.
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #49691
This adds a new API to the client-side
CoreSetup
type for accessing start contracts. This is intended to eventually replace the context pattern which will be removed in the future.The name of this API method is up for discussion: #49691 (comment)
Dev Docs
Context is being deprecated on the front-end and replaced by the
core.getStartServices()
API.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers