Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates precision definition #52024

Closed
wants to merge 1 commit into from
Closed

Updates precision definition #52024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/legacy/core_plugins/timelion/server/series_functions/precision.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
* under the License.
*/

import { i18n } from '@kbn/i18n';
import reduce from '../lib/reduce.js';
import alter from '../lib/alter.js';
import Chainable from '../lib/classes/chainable';
Expand All @@ -31,14 +30,10 @@ export default new Chainable('precision', {
{
name: 'precision',
types: ['number'],
help: i18n.translate('timelion.help.functions.precision.args.precisionHelpText', {
defaultMessage: 'Number of digits to round each value to',
}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can keep the i18n ID, but you will need to search for the same id timelion.help.functions.precision.args.precisionHelpText in the translation files and delete the translation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wylieconlon when you say i18n ID, do you mean lines 20, 34, and 39? Or just line 20?

Also, where are the translation files?

defaultMessage: 'The number of digits to truncate each value to',
}
],
help: i18n.translate('timelion.help.functions.precisionHelpText', {
defaultMessage: 'number of digits to round the decimal portion of the value to',
}),
defaultMessage: 'The number of digits to truncate the decimal portion of the value to',
fn: async function precisionFn(args) {
await alter(args, function (eachSeries, precision) {
eachSeries._meta = eachSeries._meta || {};
Expand Down