Np migration sample data

[TinaHeiligers]

Summary

Migrates sample data to the home plugin.
Addresses: #50675

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
  - [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
  - [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[flash1293]

@elasticmachine merge upstream

[elasticmachine]

merge conflict between base and head

[flash1293]

@elastic/kibana-security This PR currently has the test/api_integration/apis/general/prototype_pollution.ts test failing because the sample data api doesn't explicitly reject prototype pollution attacks anymore.

Does this test in the current form still make sense? The tested API in src/plugins/home/server/services/sample_data/routes/install.ts doesn't read the body of the request at all. Or did I use the NP validate API in the wrong way?

[legrego]

@flash1293

This PR currently has the test/api_integration/apis/general/prototype_pollution.ts test failing because the sample data api doesn't explicitly reject prototype pollution attacks anymore.

Does this test in the current form still make sense? The tested API in src/plugins/home/server/services/sample_data/routes/install.ts doesn't read the body of the request at all. Or did I use the NP validate API in the wrong way?

This test picked an arbitrary LP endpoint to test with. Its purpose is to ensure that the default route payload validation is wired up correctly from end-to-end.

Eventually we'll run out of routes to test with, which is a good thing! In the meantime, we can probably update the test to use the /api/saved_objects/_log_legacy_import route instead of the sample data routes. It looks like this route hasn't been migrated yet.

[flash1293]

Makes sense, thanks @legrego !

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 41922b6

History

• 💔 Build #14549 failed a0432cc
• 💔 Build #14519 failed bb6276c
• 💔 Build #14485 failed b26cb8f
• 💔 Build #14233 failed 1e5b6a4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[flash1293]

Closing this PR in favor of #52753