Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Add IE11-specific CSS fixes for anomalies table #49980

Merged
merged 4 commits into from
Nov 14, 2019

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Nov 1, 2019

Summary

Fixes #49197

Fix for the anomalies table being too wide in IE11. Setting table-layout to auto on the .euiTable element makes the table width display consistently in all browsers.

Screen Shot 2019-11-01 at 3 46 34 PM

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@Zacqary Zacqary added bug Fixes for quality problems that affect the customer experience v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 labels Nov 1, 2019
@Zacqary Zacqary requested a review from a team November 1, 2019 20:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@afgomez
Copy link
Contributor

afgomez commented Nov 10, 2019

I did a quick test and when I remove table-layout: fixed from the EuiBasicTable component the table falls into place. I feel it would be a cleaner solution, but I'm not sure if it's possible to pass a prop that removes the property (since it comes from Eui).

Screenshot 2019-11-10 at 10 24 36

@Zacqary
Copy link
Contributor Author

Zacqary commented Nov 11, 2019

@afgomez Thank you! That worked!

@Zacqary Zacqary marked this pull request as ready for review November 11, 2019 16:18
@Zacqary Zacqary added the release_note:skip Skip the PR/issue when compiling release notes label Nov 11, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Zacqary
Copy link
Contributor Author

Zacqary commented Nov 14, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Zacqary Zacqary merged commit c40b320 into elastic:master Nov 14, 2019
Zacqary added a commit to Zacqary/kibana that referenced this pull request Nov 14, 2019
)

* [Logs UI] Add IE11-specific CSS fixes for anomalies table

* Switch to table-layout fix
Zacqary added a commit to Zacqary/kibana that referenced this pull request Nov 14, 2019
)

* [Logs UI] Add IE11-specific CSS fixes for anomalies table

* Switch to table-layout fix
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 15, 2019
…ger-ace-theme

* 'master' of github.com:elastic/kibana: (54 commits)
  [ML] Fixes word wrap in Overview page sidebar on IE (elastic#50668)
  Upgrade to TypeScript 3.7.2 (elastic#47188)
  fix: hide 'edit' button for mobile for dashboards (elastic#50639)
  fixes conditional links tests (elastic#50642)
  [SIEM] Fix IE11 timeline drag and drop issue (elastic#50528)
  [SIEM] Add SavedQuery in Timeline (elastic#49813)
  chore(NA): remove code plugin from codeowners (elastic#50451)
  [DOCS] Adds documentation on telemetry settings (elastic#50739)
  [Logs UI] Add IE11-specific CSS fixes for anomalies table (elastic#49980)
  [DOCS][SIEM]: Change Kibana advanced settings to match UI (elastic#50679)
  Change URLs for support menu (elastic#50700)
  [Reporting] Remove any types and references to Hapi (elastic#49250)
  [DOCS] Adds note about backups to Upgrade doc (elastic#50525)
  [Logs UI] Improve infra plugin compatibility with TS 3.7 (elastic#50491)
  [Task manager] Adds ensureScheduling api to allow safer rescheduling of existing tasks (elastic#50232)
  [DOCS] Adds link to content security policy doc (elastic#50698)
  Remove duplicate but in error message (elastic#50530)
  [ML] DF Analytics: Ensure creation flyout can be opened when no jobs exist (elastic#50417)
  Add filebeat notice (elastic#49065)
  [Monitoring] De-duplicate pipeline ids based on the ephemeral_id changing (elastic#49978)
  ...

# Conflicts:
#	x-pack/legacy/plugins/grokdebugger/public/components/grok_debugger/brace_imports.ts
Zacqary added a commit that referenced this pull request Nov 18, 2019
…50742)

* [Logs UI] Add IE11-specific CSS fixes for anomalies table

* Switch to table-layout fix
Zacqary added a commit that referenced this pull request Nov 18, 2019
…50740)

* [Logs UI] Add IE11-specific CSS fixes for anomalies table

* Switch to table-layout fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs UI] Log rate anomaly table breaks the layout on IE11
3 participants