Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Log rate anomaly table breaks the layout on IE11 #49197

Closed
weltenwort opened this issue Oct 24, 2019 · 5 comments · Fixed by #49980
Closed

[Logs UI] Log rate anomaly table breaks the layout on IE11 #49197

weltenwort opened this issue Oct 24, 2019 · 5 comments · Fixed by #49980
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0

Comments

@weltenwort
Copy link
Member

Problem description

Rendering the anomaly table in on the log rate analysis page pushes the right side of the page outside the frame:

grafik

Commenting out the table rendering causes the effect to disappear.

@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience [zube]: Ready Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 labels Oct 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary
Copy link
Contributor

Zacqary commented Oct 31, 2019

Been pairing with @snide on this because I'm personally stumped. Some combination of display: table and width: 100% is causing the table element to expand to 20000-something pixels wide. Setting it to display: block instead causes each table cell to only be as wide as their widest content, not as wide as the surrounding panel.

It may be as simple as setting a max-width on the table, but it's not immediately clear what exactly that max should be considering it's a responsive layout. Also I don't know where the table is getting the 20k-wide display context from.

@snide
Copy link
Contributor

snide commented Nov 1, 2019

So I've tried to get this page to reliably load in VM/IE11 and I just can't get it consistently to load and have inspector up at the same time. The logs UI in general has a lot of issues in IE and between the auto refreshing and the inability to load inspector I'm blocked from trying to resolve this.

Likely a problem with the nesting flex groups. This feels like a smaller problem for this application in whole as far as ie11 though as I'm getting 15 second loads on the actual log viewer itself.

@Zacqary
Copy link
Contributor

Zacqary commented Nov 1, 2019

The furthest along I was able to get was passing in a max-width: 80vw to the EuiBasicTable element if Javascript detected the user was running IE11.

However this doesn't fully fix the issue, because the surrounding EuiPanel was still stretched to a minimum of something like 1500px and I didn't know why.

I can try to reproduce to get a screenshot, but I've been running into the same stability issues with IE11 and VMs so that's easier said than done.

@Zacqary
Copy link
Contributor

Zacqary commented Nov 1, 2019

So I opened a draft PR with that JS IE-detection fix just so we have something. I don't know if we even want to consider merging something like that, but here it is. #49980

Difficulties with testing and debugging are making it hard to figure out much of anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants