Add "Get Help" and "Kibana Feedback" links to the help popover #49797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
mikecote
force-pushed
the
support-menu
branch
from
87a0af9 to
32c6c36
Compare
|
This is a screenshot of what the UI looks like based on @cchaos's suggestions #49521 (comment).
|
cchaos
reviewed
Nov 1, 2019
|
Updated screenshot post PR feedback: |
|
Looks great! 👍 |
|
@elasticmachine merge upstream |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
|
Updated UI: |
💚 Build Succeeded |
|
Honestly, now looking at this list, I would just remove all the icons except for the github one. The other two don't really help describe the link. I am still concerned with all the ways the user can "provide feedback". But since this is a quick push, we can circle back at a later date. |
💚 Build Succeeded |
|
Latest screenshot: @alexfrancoeur & @cchaos if you're both good with this, I will go ahead and merge on green CI. |
💔 Build Failed |
cchaos
approved these changes
Nov 11, 2019
|
@elasticmachine merge upstream |
|
LGTM! I think we'll want to add a link out to our discuss forums as well, but not a blocker for 7.5. I'll open a separate issue to track. |
|
retest |
💚 Build Succeeded |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Nov 11, 2019
…ic#49797) * Initial work * Move links to constants * Update UI based on design and copy * Apply PR feedback * Remove unused translations * Apply requested changes * Remove some icons
This was referenced Nov 11, 2019
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Nov 11, 2019
…ic#49797) * Initial work * Move links to constants * Update UI based on design and copy * Apply PR feedback * Remove unused translations * Apply requested changes * Remove some icons
💔 Build Failed |
mikecote
added a commit
that referenced
this pull request
Nov 12, 2019
… (#50233) * Initial work * Move links to constants * Update UI based on design and copy * Apply PR feedback * Remove unused translations * Apply requested changes * Remove some icons
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
* upstream/master: [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
* upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
…skip ci] * upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
mikecote
added a commit
that referenced
this pull request
Nov 12, 2019
… (#50234) * Initial work * Move links to constants * Update UI based on design and copy * Apply PR feedback * Remove unused translations * Apply requested changes * Remove some icons
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Nov 13, 2019
elastic#49797) (elastic#50234)" This reverts commit 6145a00.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49521.
In this PR, I'm adding two links to the Kibana help menu. One link is to provide Kibana feedback and another link is to ask for help. Note the ask for help link will change if cloud is detected.