[ML] Stats bar for data frame analytics #49464

darnautov · 2019-10-28T11:00:07Z

Summary

Resolves #45381. Add the stats bar to the data frame analytics page.

Management:

Overview:

Analytics jobs page:

Anomaly Detection page:

Checklist

This was checked for cross-browser compatibility, including a check against IE11
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

elasticmachine · 2019-10-28T11:01:16Z

Pinging @elastic/ml-ui (:ml)

elasticmachine · 2019-10-28T12:18:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: dcb28b050826736cea42bd67d248b294b2497c9a

elasticmachine · 2019-10-28T18:11:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: fab0e16255d774d3f1aca2418a3763bf6c65f74d

x-pack/legacy/plugins/ml/public/data_frame_analytics/pages/analytics_management/page.tsx

jgowdyelastic · 2019-10-28T18:26:52Z

The placement of the stats bar is different to the Anomaly Explorer page which has the bar at the very top of the page (below the nav bar)
I can see why it should be underneath the "Analytics jobs" title, but should we have consistency between these pages?

alvarezmelissa87 · 2019-10-28T21:56:07Z

x-pack/legacy/plugins/ml/public/data_frame_analytics/pages/analytics_management/page.tsx

@@ -67,6 +71,11 @@ export const Page: FC = () => {
                  />
                </h1>
              </EuiTitle>
+              {stats && (
+                <div style={{ margin: '0 -14px' }}>


Probably best not to use inline style when we can help it.

alvarezmelissa87 · 2019-10-28T22:18:57Z

Overall code looks good but I agree with James's comment about consistency with the stats bar. 🤔 Do we still need the Analytics title - it may be redundant since we've got the navigation tabs. Though the experimental badge we probably need to keep.

walterra · 2019-10-29T09:35:59Z

Some context: Originally both transforms and analytics list pages had the same layout (this was before we had the overview page with both anomaly detection + analytics and the updated tab navigation), but transforms are gone now to their own plugin and its layout has been adapted to match the Kibana management section. So at the moment the analytics page is the only one left with this heading in the ML plugin. I agree both list pages' layout should be aligned. I'd pledge to keep the heading, having that is also about accessibility and having a h1. We could add the heading to the anomaly detection and have the stats bar aligned with the refresh and create buttons for both pages, something like:

<h1>Heading (optional beta/experimental badge)</h1>
<StatsBar /> | <Refresh button /> | <Create button />

This would also bring the pages more in line with the versions used in the Kibana management section, which would also allow us to add a similar link to documentation on the top right, like:

<h1>Heading (optional beta/experimental badge)</h1>           <Documentation />
<StatsBar />                             <Refresh button /> | <Create button />

In this current version of this PR the stats bar is also missing from the analytics list in the Kibana mangement section, we should add it there too (/app/kibana#/management/ml/jobs_list).

elasticmachine · 2019-11-01T19:13:10Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 46fc6fc1e21b4a5af4a8494a23e6c0434bd359c9

elasticmachine · 2019-11-11T09:41:24Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 26483b71c834e7d552723bba7ae17dbcdb62001c

x-pack/legacy/plugins/ml/public/jobs/jobs_list/jobs.js

.../data_frame_analytics/pages/analytics_management/services/analytics_service/get_analytics.ts

darnautov · 2019-11-11T15:02:53Z

retest

elasticmachine · 2019-11-11T15:59:47Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 03817fe1465f591ce2d28dbb2e104636049e37f8

elasticmachine · 2019-11-11T16:26:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: cd8a8c6f59660aa9370aa1b08785ee3ca780e4e6

peteharverson · 2019-11-11T16:43:01Z

...data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx

@@ -232,7 +248,7 @@ export const DataFrameAnalyticsList: FC<Props> = ({
  const columns = getColumns(
    expandedRowItemIds,
    setExpandedRowItemIds,
-    isManagementTable,
+    allowCreate,


I am seeing the Start / Delete actions in the Management page, whereas they should be showing when inside the ML UI. Does this allowCreate flag need inverting somewhere?

Good catch, boolean refactoring... I reverted to be aligned with anomaly detection jobs.
Check a9cac46

elasticmachine · 2019-11-11T16:48:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5307506

walterra

Great update to align the page layouts! Added some questions/suggestions.

...data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx

walterra · 2019-11-12T09:24:23Z

x-pack/legacy/plugins/ml/public/data_frame_analytics/pages/analytics_management/page.tsx

+          </EuiPageHeader>
+          <DataFrameAnalyticsList
+            blockRefresh={blockRefresh}
+            createAnalyticsForm={createAnalyticsForm}


Would it make sense to move useCreateAnalyticsForm down into DataFrameAnalyticsList so we don't need to pass createAnalyticsForm down?

it's the first thing I tried, but useCreateAnalyticsForm relied on useKibanaContext, which is not defined on the management page.

Ah, makes sense, let's leave it as it is then.

x-pack/legacy/plugins/ml/public/jobs/jobs_list/jobs.js

elasticmachine · 2019-11-12T10:15:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a9cac46

walterra

Latest changes LGTM 🎉

jgowdyelastic

LGTM

peteharverson

Tested latest changes, and LGTM

elasticmachine · 2019-11-12T12:16:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7bd5ad5

* [ML] stats for analytics jobs * [ML] alight stats position * [ML] refactor getAnalyticFactory, remove analytics stats bar component * [ML] align layout for anomaly detection * [ML] align layout * [ML] show failed jobs count * [ML] Anomaly detection jobs header * [ML] test * [ML] fix action columns * [ML] add type for createAnalyticsForm * [ML] move page title, prettier formatting

* upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)

…skip ci] * upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)

* [ML] stats for analytics jobs * [ML] alight stats position * [ML] refactor getAnalyticFactory, remove analytics stats bar component * [ML] align layout for anomaly detection * [ML] align layout * [ML] show failed jobs count * [ML] Anomaly detection jobs header * [ML] test * [ML] fix action columns * [ML] add type for createAnalyticsForm * [ML] move page title, prettier formatting

…-fallback * 'master' of github.com:elastic/kibana: Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120) Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464)

…ger-ace-theme * 'master' of github.com:elastic/kibana: (56 commits) [ML] Server info service refactor (elastic#50302) Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120) Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) ...

darnautov requested a review from a team as a code owner October 28, 2019 11:00

darnautov self-assigned this Oct 28, 2019

darnautov added :ml Feature:Data Frame Analytics ML data frame analytics features labels Oct 28, 2019

darnautov added release_note:enhancement v7.6.0 v8.0.0 labels Oct 28, 2019

darnautov requested review from walterra, jgowdyelastic and alvarezmelissa87 October 28, 2019 11:01

jgowdyelastic reviewed Oct 28, 2019

View reviewed changes

x-pack/legacy/plugins/ml/public/data_frame_analytics/pages/analytics_management/page.tsx Outdated Show resolved Hide resolved

alvarezmelissa87 reviewed Oct 28, 2019

View reviewed changes

darnautov force-pushed the ML-45381-analytics-stats-bar branch from fab0e16 to 46fc6fc Compare November 1, 2019 17:55

darnautov requested a review from a team as a code owner November 1, 2019 17:55

darnautov requested review from jgowdyelastic, alvarezmelissa87 and peteharverson November 1, 2019 17:59

darnautov force-pushed the ML-45381-analytics-stats-bar branch from 46fc6fc to 26483b7 Compare November 11, 2019 08:23

peteharverson reviewed Nov 11, 2019

View reviewed changes

x-pack/legacy/plugins/ml/public/jobs/jobs_list/jobs.js Outdated Show resolved Hide resolved

.../data_frame_analytics/pages/analytics_management/services/analytics_service/get_analytics.ts Show resolved Hide resolved

darnautov requested a review from peteharverson November 11, 2019 14:45

[ML] stats for analytics jobs

8e0dfa7

darnautov added 3 commits November 11, 2019 16:35

[ML] show failed jobs count

8abeadd

[ML] Anomaly detection jobs header

50ffc39

[ML] test

5307506

darnautov force-pushed the ML-45381-analytics-stats-bar branch from cd8a8c6 to 5307506 Compare November 11, 2019 15:36

peteharverson reviewed Nov 11, 2019

View reviewed changes

[ML] fix action columns

a9cac46

darnautov requested a review from peteharverson November 12, 2019 09:18

walterra reviewed Nov 12, 2019

View reviewed changes

darnautov added 2 commits November 12, 2019 11:27

[ML] add type for createAnalyticsForm

c4603cd

[ML] move page title, prettier formatting

7bd5ad5

darnautov requested a review from walterra November 12, 2019 10:55

walterra approved these changes Nov 12, 2019

View reviewed changes

jgowdyelastic approved these changes Nov 12, 2019

View reviewed changes

peteharverson approved these changes Nov 12, 2019

View reviewed changes

darnautov merged commit b9a43a1 into elastic:master Nov 12, 2019

darnautov deleted the ML-45381-analytics-stats-bar branch November 12, 2019 12:42

darnautov mentioned this pull request Nov 12, 2019

[7.x] [ML] Stats bar for data frame analytics (#49464) #50297

Merged

alvarezmelissa87 mentioned this pull request Nov 12, 2019

[ML] DF Analytics: Ensure creation flyout can be opened when no jobs exist #50417

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Stats bar for data frame analytics #49464

[ML] Stats bar for data frame analytics #49464

darnautov commented Oct 28, 2019 •

edited

Loading

elasticmachine commented Oct 28, 2019

elasticmachine commented Oct 28, 2019

elasticmachine commented Oct 28, 2019

jgowdyelastic commented Oct 28, 2019

alvarezmelissa87 Oct 28, 2019

alvarezmelissa87 commented Oct 28, 2019

walterra commented Oct 29, 2019

elasticmachine commented Nov 1, 2019

elasticmachine commented Nov 11, 2019

darnautov commented Nov 11, 2019

elasticmachine commented Nov 11, 2019

elasticmachine commented Nov 11, 2019

peteharverson Nov 11, 2019

darnautov Nov 12, 2019

elasticmachine commented Nov 11, 2019

walterra left a comment

walterra Nov 12, 2019

darnautov Nov 12, 2019

walterra Nov 12, 2019

elasticmachine commented Nov 12, 2019

walterra left a comment

jgowdyelastic left a comment

peteharverson left a comment

elasticmachine commented Nov 12, 2019

[ML] Stats bar for data frame analytics #49464

[ML] Stats bar for data frame analytics #49464

Conversation

darnautov commented Oct 28, 2019 • edited Loading

Summary

Checklist

elasticmachine commented Oct 28, 2019

elasticmachine commented Oct 28, 2019

💚 Build Succeeded

elasticmachine commented Oct 28, 2019

💚 Build Succeeded

jgowdyelastic commented Oct 28, 2019

alvarezmelissa87 Oct 28, 2019

Choose a reason for hiding this comment

alvarezmelissa87 commented Oct 28, 2019

walterra commented Oct 29, 2019

elasticmachine commented Nov 1, 2019

💚 Build Succeeded

elasticmachine commented Nov 11, 2019

💚 Build Succeeded

darnautov commented Nov 11, 2019

elasticmachine commented Nov 11, 2019

💔 Build Failed

elasticmachine commented Nov 11, 2019

💔 Build Failed

peteharverson Nov 11, 2019

Choose a reason for hiding this comment

darnautov Nov 12, 2019

Choose a reason for hiding this comment

elasticmachine commented Nov 11, 2019

💚 Build Succeeded

walterra left a comment

Choose a reason for hiding this comment

walterra Nov 12, 2019

Choose a reason for hiding this comment

darnautov Nov 12, 2019

Choose a reason for hiding this comment

walterra Nov 12, 2019

Choose a reason for hiding this comment

elasticmachine commented Nov 12, 2019

💚 Build Succeeded

walterra left a comment

Choose a reason for hiding this comment

jgowdyelastic left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

elasticmachine commented Nov 12, 2019

💚 Build Succeeded

darnautov commented Oct 28, 2019 •

edited

Loading