Timelion: Move datemath parsing to the client #47813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Timelion
💔 Build Failed |
💚 Build Succeeded |
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
Just noticed the angular app has it's own request handler, have to fix it there separately. |
💚 Build Succeeded |
ryankeairns
approved these changes
Oct 16, 2019
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 22, 2019
flash1293
added a commit
that referenced
this pull request
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12678
This PR moves the parsing of the datemath expression set by the timepicker to the client where it can use the same settings as regular visualizations. The dates sent to the server become ISO-formatted dates that can be used directly.
The original error was caused by the server not taking the client timezone into account when parsing date math, by using the same function as the rest of Kibana this isn't a problem anymore.
It also fixes a CSS issue in the timelion app (not a problem in the Visualize vis) that caused the last query stats to display with 100% of the screen height:
before:
after:
The changed class
kuiLocalTitleis not used anywhere else in Kibana.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriatelyDev Docs
Timelion server API
The server side api of Timelion
/api/timelion/runused to accept datemath strings (likenow) for thetime.fromandtime.toproperties. This PR removes support for datemath, from now on only ISO8601 encoded strings are supported.