Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow datemath in canvas timelion function #51918

Closed
timroes opened this issue Nov 29, 2019 · 2 comments · Fixed by #52159
Closed

Allow datemath in canvas timelion function #51918

timroes opened this issue Nov 29, 2019 · 2 comments · Fixed by #52159
Assignees
@flash1293
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Canvas Feature:Timelion Timelion app and visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0

Comments

@timroes
Copy link
Contributor

timroes commented Nov 29, 2019 •
edited
Loading

Since #47813 the canvas function doesn't compile datemath that has been passed to it via the from/to arguments anymore (it still works when coming in from the timefilter context (since that one calculates it as full ISO dates).

We must make sure that this still works, since that function is exposed to the user so they can (and should) be able to use datemath there.

@ canvas team: we broke it, we fix it :-)
@timroes timroes added bug Fixes for quality problems that affect the customer experience blocker Feature:Timelion Timelion app and visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0 labels Nov 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@flash1293 flash1293 mentioned this issue Dec 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flash1293 flash1293

Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Canvas Feature:Timelion Timelion app and visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable datemath in from/to canvas timelion args flash1293/kibana
4 participants
@timroes @flash1293 @marius-dr @elasticmachine