Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #4675

Merged
merged 19 commits into from
Aug 17, 2015
Merged

Fix build #4675

merged 19 commits into from
Aug 17, 2015

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Aug 14, 2015

Fixes #4597

Revisits some of the existing build tasks and handles building and uploading with the latest changes from #4611

@BigFunger BigFunger assigned w33ble and unassigned BigFunger Aug 17, 2015
@BigFunger
Copy link
Contributor

Works in Windows 8.1

@w33ble
Copy link
Contributor

w33ble commented Aug 17, 2015

After a plugin install, memory use is pretty high. It drops back to normal levels when you restart the process though. @spalger is it just a matter of the OS not taking memory away from the process when it's done with it?

screenshot 2015-08-17 13 31 38

Under normal operation, it seems to stay around 140bm-170mb.

@w33ble
Copy link
Contributor

w33ble commented Aug 17, 2015

The Windows build does not work on 32-bit versions of Windows. Maybe we're shipping the wrong version of node?

screenshot 2015-08-17 13 37 23

Checking the node.exe with file on Mac shows PE32+, and I think the + might indicate a 64-bit binary.

screenshot 2015-08-17 13 42 49

@w33ble w33ble assigned spalger and unassigned w33ble Aug 17, 2015
@spalger
Copy link
Contributor Author

spalger commented Aug 17, 2015

@w33ble were we previously shipping the 32bit node? I didn't mean to change that but I did

@w33ble
Copy link
Contributor

w33ble commented Aug 17, 2015

Yup, 32-bit will run on both versions of Windows seemlessly, 64-bit only runs on 64-bit Windows.

We've always shipped 32-bit Windows, 64-bit Darwin and both Linux builds of Node.

@spalger
Copy link
Contributor Author

spalger commented Aug 17, 2015

@w33ble as for memory usage after plugin installation I would categorize that as a known issue, created #4683 to track it.

@w33ble
Copy link
Contributor

w33ble commented Aug 17, 2015

32-bit Windows is working now. I see the following message when starting it up though, and also when installing plugins:

INFO: Could not find files for the given pattern(s).

It all works, so it's not a big deal, but it's worth mentioning. @BigFunger doesn't see this in 64-bit Windows, seems to just be me.

w33ble added a commit that referenced this pull request Aug 17, 2015
@w33ble w33ble merged commit ce19ecc into elastic:master Aug 17, 2015
@Quiri
Copy link

Quiri commented Aug 19, 2015

Doesn't work on Ubuntu 14.04 64bit:

module.js:340
    throw err;
          ^
Error: Cannot find module 'babel/register'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/home/kirill/kibana4.2/kibana/src/cli/index.js:1:63)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)

EDIT

after installing babel, lodash and requirefrom with npm, I get this error:

module.js:340
    throw err;
          ^
Error: Cannot find module '/home/kirill/kibana4.2/src/utils/packageJson'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at requireModule (/home/kirill/kibana4.2/node_modules/requirefrom/index.js:24:10)
    at Object.<anonymous> (/home/kirill/kibana4.2/kibana/src/cli/cli.js:4:11)
    at Module._compile (module.js:456:26)
    at normalLoader (/home/kirill/kibana4.2/node_modules/babel/node_modules/babel-core/lib/api/register/node.js:199:5)
    at Object.require.extensions.(anonymous function) [as .js] (/home/kirill/kibana4.2/node_modules/babel/node_modules/babel-core/lib/api/register/node.js:216:7)
    at Module.load (module.js:356:32)

@spalger
Copy link
Contributor Author

spalger commented Aug 19, 2015

@Quiri Have you followed the steps in the CONTRIBUTING.md?

@Quiri
Copy link

Quiri commented Aug 19, 2015

@spalger Stupid me, I discovered CONTRIBUTING.md right after posting the previous comment. Now it works!

@spalger
Copy link
Contributor Author

spalger commented Aug 19, 2015

@Quiri Glad to hear!

@spalger spalger deleted the fix/build branch February 25, 2016 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants