-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build #4675
Fix build #4675
Conversation
Works in Windows 8.1 |
After a plugin install, memory use is pretty high. It drops back to normal levels when you restart the process though. @spalger is it just a matter of the OS not taking memory away from the process when it's done with it? Under normal operation, it seems to stay around 140bm-170mb. |
@w33ble were we previously shipping the 32bit node? I didn't mean to change that but I did |
Yup, 32-bit will run on both versions of Windows seemlessly, 64-bit only runs on 64-bit Windows. We've always shipped 32-bit Windows, 64-bit Darwin and both Linux builds of Node. |
32-bit Windows is working now. I see the following message when starting it up though, and also when installing plugins:
It all works, so it's not a big deal, but it's worth mentioning. @BigFunger doesn't see this in 64-bit Windows, seems to just be me. |
Doesn't work on Ubuntu 14.04 64bit:
EDIT after installing
|
@Quiri Have you followed the steps in the CONTRIBUTING.md? |
@spalger Stupid me, I discovered CONTRIBUTING.md right after posting the previous comment. Now it works! |
@Quiri Glad to hear! |
Fixes #4597
Revisits some of the existing build tasks and handles building and uploading with the latest changes from #4611