Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n test helper documentation. #46298

Merged
merged 3 commits into from
Jan 4, 2021
Merged

Conversation

sainthkh
Copy link
Contributor

Summary

Fixes #44975.

In #44580, new test helpers are created to be used with FormattedMessage. But documentation wasn't updated with that PR.

So, I've written one for that.

You can read the rendered version here.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@sainthkh
Copy link
Contributor Author

sainthkh commented Nov 4, 2019

When you (Kibana team) are ready to handle this, please leave me a comment. I'll come back to handle the conflicts and bugs.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation looks pretty good for me. Thank you for adding it.

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for submitting this

@Bamieh
Copy link
Member

Bamieh commented Jan 8, 2020

@elasticmachine merge upstream

@Bamieh Bamieh added backport:skip This commit does not require backporting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes and removed DONOTUSETeam:Stack Services backport:skip This commit does not require backporting labels Jan 8, 2020
@lukeelmers
Copy link
Member

@elasticmachine merge upstream

@kibanamachine kibanamachine requested review from a team as code owners December 30, 2020 18:35
@lukeelmers lukeelmers added the backport:skip This commit does not require backporting label Jan 4, 2021
@lukeelmers lukeelmers changed the title Added test helper documentation. Add i18n test helper documentation. Jan 4, 2021
@lukeelmers lukeelmers merged commit 77947b6 into elastic:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting 💝community docs Project:i18n release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing documentation for i18n test helpers.
8 participants