Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing documentation for i18n test helpers. #44975

Closed
sainthkh opened this issue Sep 6, 2019 · 2 comments · Fixed by #46298
Closed

Writing documentation for i18n test helpers. #44975

sainthkh opened this issue Sep 6, 2019 · 2 comments · Fixed by #46298
Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@sainthkh
Copy link
Contributor

sainthkh commented Sep 6, 2019

In #44580, 2 new test helper functions are added for FormattedMessage component. But the documents aren't updated yet.

We talked about updating GUIDELINE.md and maybe i18n/README.md.

But the PR is merged and discussion isn't going on. So, I've written this issue not to forget about that.
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services

@sainthkh sainthkh mentioned this issue Sep 20, 2019
Merged
2 tasks
@lukeelmers lukeelmers added Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add i18n test helper documentation. sainthkh/kibana
5 participants
@lukeelmers @bmcconaghy @sainthkh @rashmivkulkarni @elasticmachine