Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeOption: Get rid of ts-ignore #45902

Merged
merged 5 commits into from
Sep 24, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import React, { useState } from 'react';
import { EuiFormRow, EuiRange } from '@elastic/eui';
import { EuiFormRow, EuiRange, EuiRangeProps } from '@elastic/eui';
import { i18n } from '@kbn/i18n';

interface RangeOptionProps<ParamName extends string> {
Expand Down Expand Up @@ -50,10 +50,9 @@ function RangeOption<ParamName extends string>({
values: { min, max },
});

const onChangeHandler = (
{ target: { valueAsNumber } }: React.ChangeEvent<HTMLInputElement>,
isValid: boolean
) => {
const onChangeHandler: EuiRangeProps['onChange'] = (event, isValid) => {
const { valueAsNumber } = event.target as HTMLInputElement; // since we don't show ticks on EuiRange, the target will definitely be HTMLInputElement type, so we can cast it directly.

setStateValue(valueAsNumber);
setIsValidState(isValid);

Expand All @@ -72,7 +71,6 @@ function RangeOption<ParamName extends string>({
showInput={showInput}
step={step}
value={stateValue}
// @ts-ignore
onChange={onChangeHandler}
/>
</EuiFormRow>
Expand Down