Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeOption: Get rid of ts-ignore #45902

Merged
merged 5 commits into from
Sep 24, 2019

Conversation

maryia-lapata
Copy link
Contributor

Summary

Remove @ts-ignore after elastic/eui#2349 resolved.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@maryia-lapata maryia-lapata added release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0 labels Sep 17, 2019
@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@maryia-lapata
Copy link
Contributor Author

@elasticmachine merge upstream

@maryia-lapata maryia-lapata added the Feature:Vis Editor Visualization editor issues label Sep 23, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata marked this pull request as ready for review September 23, 2019 11:21
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryia-lapata maryia-lapata merged commit 7ae2d9c into elastic:master Sep 24, 2019
@maryia-lapata maryia-lapata deleted the small-fixes branch September 24, 2019 11:11
maryia-lapata added a commit to maryia-lapata/kibana that referenced this pull request Sep 24, 2019
* Get rid of ts-ignore

* Update range.tsx

* Refactoring
maryia-lapata added a commit that referenced this pull request Sep 24, 2019
* Get rid of ts-ignore

* Update range.tsx

* Refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants