-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pipeline scripts with runbld #45844
Merged
brianseeders
merged 8 commits into
elastic:master
from
brianseeders:fix/pipelines-runbld-simple
Sep 18, 2019
Merged
Run pipeline scripts with runbld #45844
brianseeders
merged 8 commits into
elastic:master
from
brianseeders:fix/pipelines-runbld-simple
Sep 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Feature:CI
Continuous integration
v7.4.0
v7.5.0
v7.3.2
v6.8.4
test-pipelines
labels
Sep 16, 2019
💔 Build Failed |
💚 Build Succeeded |
brianseeders
force-pushed
the
fix/pipelines-runbld-simple
branch
from
September 17, 2019 17:35
fd87a92
to
8887be1
Compare
Oops, please ignore this @elastic/kibana-platform - I edited a random test to force a failure and you are a codeowner. It will be reverted soon |
spalger
reviewed
Sep 17, 2019
💔 Build Failed |
spalger
approved these changes
Sep 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once the failing tests are removed
brianseeders
force-pushed
the
fix/pipelines-runbld-simple
branch
from
September 17, 2019 19:50
0c113be
to
781f5f0
Compare
This reverts commit 8887be1837fa7fd3afb362dd2250618c1641d572.
brianseeders
force-pushed
the
fix/pipelines-runbld-simple
branch
from
September 17, 2019 20:37
781f5f0
to
e6b119e
Compare
💚 Build Succeeded |
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders
added a commit
that referenced
this pull request
Sep 18, 2019
brianseeders
added a commit
that referenced
this pull request
Sep 18, 2019
brianseeders
added a commit
that referenced
this pull request
Sep 18, 2019
brianseeders
added a commit
that referenced
this pull request
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:CI
Continuous integration
release_note:skip
Skip the PR/issue when compiling release notes
test-pipelines
v6.8.4
v7.3.2
v7.4.0
v7.5.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45605
Jenkins wasn't actually invoking runbld when running scripts.
Runbld normally processes junit files at the end of execution. Since we are executing multiple times per worker in parallel, we need to wait until the end to process junit reports all at once.
I've created a separate runbld config that effectively disables junit reporting. The config values from the default, system-level config are inherited. By default, scripts in the pipeline are called in such a way that junit outputs will not be read.
runbld also adds an old version of Java to the PATH, which led to me adding the es/java env set up from
checkout_sibling_es
tosetup_env.sh