Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pipeline scripts with runbld #45844

Merged
merged 8 commits into from
Sep 18, 2019

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Sep 16, 2019

Fixes #45605

Jenkins wasn't actually invoking runbld when running scripts.

Runbld normally processes junit files at the end of execution. Since we are executing multiple times per worker in parallel, we need to wait until the end to process junit reports all at once.

I've created a separate runbld config that effectively disables junit reporting. The config values from the default, system-level config are inherited. By default, scripts in the pipeline are called in such a way that junit outputs will not be read.

runbld also adds an old version of Java to the PATH, which led to me adding the es/java env set up from checkout_sibling_es to setup_env.sh

@brianseeders brianseeders added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:CI Continuous integration v7.4.0 v7.5.0 v7.3.2 v6.8.4 test-pipelines labels Sep 16, 2019
@brianseeders brianseeders requested a review from a team as a code owner September 16, 2019 21:40
@brianseeders brianseeders self-assigned this Sep 16, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@brianseeders brianseeders force-pushed the fix/pipelines-runbld-simple branch from fd87a92 to 8887be1 Compare September 17, 2019 17:35
@brianseeders brianseeders requested a review from a team as a code owner September 17, 2019 17:35
@brianseeders
Copy link
Contributor Author

Oops, please ignore this @elastic/kibana-platform - I edited a random test to force a failure and you are a codeowner. It will be reverted soon

Jenkinsfile Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the failing tests are removed

@brianseeders brianseeders force-pushed the fix/pipelines-runbld-simple branch from 0c113be to 781f5f0 Compare September 17, 2019 19:50
@brianseeders brianseeders removed the request for review from a team September 17, 2019 19:50
@brianseeders brianseeders force-pushed the fix/pipelines-runbld-simple branch from 781f5f0 to e6b119e Compare September 17, 2019 20:37
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@brianseeders brianseeders merged commit 4142659 into elastic:master Sep 18, 2019
@brianseeders brianseeders deleted the fix/pipelines-runbld-simple branch September 18, 2019 14:38
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders added a commit to brianseeders/kibana that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders added a commit that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders added a commit that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders added a commit that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
brianseeders added a commit that referenced this pull request Sep 18, 2019
Change how runbld is invoked, and skip junit processing by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes test-pipelines v6.8.4 v7.3.2 v7.4.0 v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pipeline] runbld isn't reporting errors to build-stats
3 participants