Skip to content

Commit

Permalink
Revert "Force some tests to fail temporarily for testing"
Browse files Browse the repository at this point in the history
This reverts commit 8887be1837fa7fd3afb362dd2250618c1641d572.
  • Loading branch information
brianseeders committed Sep 17, 2019
1 parent 76d6053 commit e6b119e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
4 changes: 0 additions & 4 deletions src/core/server/server.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,3 @@ test(`doesn't setup core services if config validation fails`, async () => {
expect(mockPluginsService.setup).not.toHaveBeenCalled();
expect(mockLegacyService.setup).not.toHaveBeenCalled();
});

test(`FORCE_FAILURE`, () => {
expect(false).toBe(true);
});
5 changes: 2 additions & 3 deletions test/functional/apps/dashboard/dashboard_listing.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,9 @@ export default function ({ getService, getPageObjects }) {
});

describe('create prompt', () => {
it('FORCE_FAILURE appears when there are no dashboards', async function () {
it('appears when there are no dashboards', async function () {
const promptExists = await PageObjects.dashboard.getCreateDashboardPromptExists();
expect(promptExists).to.be(false);
expect(true).to.be(false);
expect(promptExists).to.be(true);
});

it('creates a new dashboard', async function () {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,14 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
await esArchiver.unload('visualize/default');
});

it('FORCE_FAILURE shows visualize navlink', async () => {
it('shows visualize navlink', async () => {
await PageObjects.common.navigateToApp('home', {
basePath: '/s/custom_space',
});
const navLinks = (await appsMenu.readLinks()).map(
(link: Record<string, string>) => link.text
);
expect(navLinks).to.contain('FORCE_FAILURE');
expect(false).to.be(true);
expect(navLinks).to.contain('Visualize');
});

it(`can view existing Visualization`, async () => {
Expand Down

0 comments on commit e6b119e

Please sign in to comment.