Move timefilter and timehistory instantiation ⇒ data plugin #44783

lizozom · 2019-09-04T15:41:34Z

Summary

Added timefilter as a dependency to FilterService
Added timeHistory as a dependency to QueryBar
Pass timefilter as a dependency to changeTimeFilter and onBrushEvent functions
Added TimefilterContract and TimeHistoryContract types
Replaced isAutoRefreshSelectorEnabled and isTimeRangeSelectorEnabled public members of timefilter with appropriate get functions.
Made timefilter.getForceNow private
Created timefilter mock and updated all relevant tests.

Dev Docs

Move value_suggestions into NP and expose data.getSuggestions on start contract.

In old platform:

    import { npStart } from 'ui/new_platform';
    const timefilter: TimefilterContract = npStart.plugins.data.timefilter.timefilter;
    const timeHistory: TimeHistoryContract = npStart.plugins.data.timefilter.timeHistory;

In new platform:

    public start(core, plugins) {
       ...
       const timefilter: TimefilterContract = plugins.data.timefilter.timefilter;
       const timeHistory: TimeHistoryContract = plugins.data.timefilter.timeHistory;
    }

Also, in timefilter the following API changes were made:

Replaced timefilter.isAutoRefreshSelectorEnabled member with timefilter.isAutoRefreshSelectorEnabled()
Replaced timefilter.isTimeRangeSelectorEnabled with timefilter.isTimeRangeSelectorEnabled()
timefilter.getForceNow is now private

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-09-04T16:24:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-04T17:34:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-04T19:00:35Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-05T10:29:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-05T13:55:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-05T15:54:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-12T15:17:07Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-15T11:07:46Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-15T17:05:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-16T09:09:55Z

Pinging @elastic/kibana-app-arch

…ilter/move-data-2

elasticmachine · 2019-09-23T11:13:22Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-23T13:11:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

lizozom · 2019-09-23T14:34:56Z

Copying @peteharverson 's feedback here:

I see you are switching back the mocks in that PR to use ui/timefilter. I am a bit confused as Josh changed them to use ui/new_platform quite recently

lizozom · 2019-09-23T14:44:29Z

@peteharverson

ML uses timefilter extensively, and moving it into data plugin, introduces additional dependencies that needed to be mocked, just by importing timefilter.

(For example ui/registry/field_formats,ui/persisted_logs, ui/value_suggestions and more.)
(On a side note, these dependencies are going away one by one!)

I could mock them independently, but since most tests don't even need timefilter, I chose to mock the whole ui/timefilter import. A side effect of this, was making the ui/new_platform mock redundant, so I removed it.

i.e. mocking ui/timefilter mocks the data plugin, which uses mocked ui/new_platform core plugins anyway.

I hope this makes it clearer.

elasticmachine · 2019-09-23T15:30:38Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ppisljar

LGTM with one minor comment, tested on chrome linux.

the issue with not reloading settings can be addressed in separate PR as its also present on master

src/legacy/core_plugins/data/public/filter/filter_manager/lib/extract_time_filter.ts

ppisljar · 2019-09-24T08:02:46Z

src/legacy/core_plugins/data/public/timefilter/timefilter_service.ts

+
+export class TimefilterService {
+  public setup({ uiSettings }: TimeFilterServiceDependencies): TimefilterSetup {
+    const timefilterConfig = {


hmm not sure if this is (was) working fine:

you start kibana, TimefilterService gets started and reads the uiSettings

you go to management -> kibana advanced settings and you change them

they don't apply until you refresh your browser (to reload kibana)

…ilter/move-data-2

peteharverson

Tested ML, and edits LGTM.

elasticmachine · 2019-09-24T12:06:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-24T13:38:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…44783) * Create timefilter service * Pass timehistory as a dependency to query bar * Updated timefilter tests and mocks * Fix jest test * Fixed bad import path * updated xpack test * make history optional on query bar * Fixed chart_utils test * Fixed page.test by mocking timefilter * Fixed explorer_charts_container_service test by mocking timefilter * Fixed explorer_chart_distribution test by mocking timefilter * Fixed explorer_chart_single_metric test by mocking timefilter * Fixed explorer_charts_container test by mocking timefilter and removing some unneeded initialization * Fixed explorer_swimlane tesy by mocking timefilter * Added missing functions to uiTimefilterMock to fix top_nav test * Fixed timeseries_chart test by mocking timefilter * remove bad merge * mock field formats * mock field formats * rename timefilter boolean getters * fix ml mocks * ml mocks

…46467) * Create timefilter service * Pass timehistory as a dependency to query bar * Updated timefilter tests and mocks * Fix jest test * Fixed bad import path * updated xpack test * make history optional on query bar * Fixed chart_utils test * Fixed page.test by mocking timefilter * Fixed explorer_charts_container_service test by mocking timefilter * Fixed explorer_chart_distribution test by mocking timefilter * Fixed explorer_chart_single_metric test by mocking timefilter * Fixed explorer_charts_container test by mocking timefilter and removing some unneeded initialization * Fixed explorer_swimlane tesy by mocking timefilter * Added missing functions to uiTimefilterMock to fix top_nav test * Fixed timeseries_chart test by mocking timefilter * remove bad merge * mock field formats * mock field formats * rename timefilter boolean getters * fix ml mocks * ml mocks

rayafratkina · 2019-11-13T21:50:48Z

@lizozom can you please add a DevDocs section?

elasticmachine · 2019-11-14T18:57:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 8e229bd

lizozom added the release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. label Sep 4, 2019

lizozom self-assigned this Sep 4, 2019

lizozom changed the title ~~Move timefilter and timehistory instantiation into data plugin~~ Move timefilter and timehistory instantiation ⇒ data plugin Sep 4, 2019

lizozom mentioned this pull request Sep 4, 2019

Move Filter \ Timefilter \ Query Services ⇒ NP #44377

Closed

26 tasks

lizozom force-pushed the newplatform/timefilter/move-data-2 branch from 31da752 to f7adb55 Compare September 4, 2019 18:18

lizozom added Feature:NP Migration Team:AppArch v7.5.0 v8.0.0 labels Sep 16, 2019

Liza K added 11 commits September 16, 2019 19:43

Create timefilter service

94589dc

Pass timehistory as a dependency to query bar

a4b77a0

Updated timefilter tests and mocks

dd0abde

Fix jest test

8bbf29a

Fixed bad import path

889101b

updated xpack test

7a9f75f

make history optional on query bar

926f948

Fixed chart_utils test

f0ef969

Fixed page.test by mocking timefilter

8c21433

Fixed explorer_charts_container_service test by mocking timefilter

c433005

Fixed explorer_chart_distribution test by mocking timefilter

0ac4161

Liza K added 2 commits September 23, 2019 12:19

Merge remote-tracking branch 'upstream/master' into newplatform/timef…

791f758

…ilter/move-data-2

remove bad merge

a9b4bed

mock field formats

587c6c5

mock field formats

fd83ebe

lizozom added the review label Sep 23, 2019

ppisljar approved these changes Sep 24, 2019

View reviewed changes

Liza K added 3 commits September 24, 2019 11:34

Merge remote-tracking branch 'upstream/master' into newplatform/timef…

b46915a

…ilter/move-data-2

rename timefilter boolean getters

e6ea811

fix ml mocks

9143806

peteharverson approved these changes Sep 24, 2019

View reviewed changes

ml mocks

8e229bd

lizozom merged commit c28ce03 into elastic:master Sep 24, 2019

lizozom mentioned this pull request Sep 24, 2019

[7.x] Move timefilter and timehistory instantiation ⇒ data plugin (#44783) #46467

Merged

chrisronline mentioned this pull request Nov 13, 2019

[Meta] Prepare stack monitoring for new platform #33671

Closed

8 tasks

lizozom deleted the newplatform/timefilter/move-data-2 branch November 14, 2019 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move timefilter and timehistory instantiation ⇒ data plugin #44783

Move timefilter and timehistory instantiation ⇒ data plugin #44783

lizozom commented Sep 4, 2019 •

edited

Loading

elasticmachine commented Sep 4, 2019

elasticmachine commented Sep 4, 2019

elasticmachine commented Sep 4, 2019

elasticmachine commented Sep 5, 2019

elasticmachine commented Sep 5, 2019

elasticmachine commented Sep 5, 2019

elasticmachine commented Sep 12, 2019

elasticmachine commented Sep 15, 2019

elasticmachine commented Sep 15, 2019

elasticmachine commented Sep 16, 2019

elasticmachine commented Sep 23, 2019

elasticmachine commented Sep 23, 2019

lizozom commented Sep 23, 2019

lizozom commented Sep 23, 2019 •

edited

Loading

elasticmachine commented Sep 23, 2019

ppisljar left a comment

ppisljar Sep 24, 2019

peteharverson left a comment

elasticmachine commented Sep 24, 2019

elasticmachine commented Sep 24, 2019

rayafratkina commented Nov 13, 2019

elasticmachine commented Nov 14, 2019

Move timefilter and timehistory instantiation ⇒ data plugin #44783

Move timefilter and timehistory instantiation ⇒ data plugin #44783

Conversation

lizozom commented Sep 4, 2019 • edited Loading

Summary

Dev Docs

Checklist

For maintainers

elasticmachine commented Sep 4, 2019

💔 Build Failed

elasticmachine commented Sep 4, 2019

💔 Build Failed

elasticmachine commented Sep 4, 2019

💔 Build Failed

elasticmachine commented Sep 5, 2019

💔 Build Failed

elasticmachine commented Sep 5, 2019

💔 Build Failed

elasticmachine commented Sep 5, 2019

💔 Build Failed

elasticmachine commented Sep 12, 2019

💔 Build Failed

elasticmachine commented Sep 15, 2019

💔 Build Failed

elasticmachine commented Sep 15, 2019

💚 Build Succeeded

elasticmachine commented Sep 16, 2019

elasticmachine commented Sep 23, 2019

💔 Build Failed

elasticmachine commented Sep 23, 2019

💔 Build Failed

lizozom commented Sep 23, 2019

lizozom commented Sep 23, 2019 • edited Loading

elasticmachine commented Sep 23, 2019

💚 Build Succeeded

ppisljar left a comment

Choose a reason for hiding this comment

ppisljar Sep 24, 2019

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

elasticmachine commented Sep 24, 2019

💔 Build Failed

elasticmachine commented Sep 24, 2019

💚 Build Succeeded

rayafratkina commented Nov 13, 2019

elasticmachine commented Nov 14, 2019

💔 Build Failed

lizozom commented Sep 4, 2019 •

edited

Loading

lizozom commented Sep 23, 2019 •

edited

Loading