-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] Prepare stack monitoring for new platform #33671
Comments
Pinging @elastic/stack-monitoring |
@chrisronline Nice! Thanks for putting this together! Do you know when we want to have this done by? It might be good to find a home for this in the Stack Monitoring project board. |
@cachedout Great question. It needs to be done by 8.0 |
K, I'll take care of finding a home for this on the board. Thanks! |
I've opened the first PR for this work (#34566) that outlines some of the initial effort required to remove angular entirely. It's actually quite a bit of work, considering we need to provide custom solutions for routing and global state management. We have some time to get all of this ready, but this effort will be large and require a bit of time to pull off. We should try and pick away at pieces of this as we go. My PR should probably be updated to accommodate a periodic roll out plan of attack where we can convert a few views here and there at a time instead of saving one huge PR for the end. I'll work on that next. |
@chrisronline What do you think about trying to break these up into some more discrete sets of tasks that we can put into the project board to monitor our progress? |
Sure, I'll revisit this very soon and add some separate tasks, as I see them |
As a reminder, @monicasarbu would also like us to please review the Logstash Pipeline Viewer in the management app as well. (We don't need to migrate it, but just see what the work would look like.) I don't think that's being tracked anywhere else so I'm mentioning it here. |
@chrisronline Where does #34566 fit in with where we are today? Is your plan to come back to that? |
I think the plan is for @igoristic to continue/restart that effort. @igoristic Feel free to reach out with any questions about the work I did there - we don't have to keep any of it, but it might show you some of the thoughts I had about how the client side might work without angular |
@chrisronline Thanks, this is great stuff! I might be able to reuse some of it |
@igoristic I am reviewing the items for 7.6 and noticed that there are two items under the The FF for 7.6 is Jan 14. As always, we need to provide enough time to go through a review process. Do you anticipate any difficulty in getting through the remaining items for 7.6 before the end of the year? As always, updates are very appreciated. Thanks! |
@chrisronline Similar question for you in terms of whether or not we should check off the first item in 7.5 list since the referenced PR is merged. |
They are not yet merged, but mostly completed here: #51823 I'll update the progress once I merge it to |
Could you switch to elasticsearch client & licensing plugin API exposed from start contract when you finish migrating the remainings to the Kibana Platform? We are deprecating elasticsearch API exposed from setup contract, so it's better to refactor the code right away not to get back to the problem later. |
@restrry Yes that should be fine. What's the timeline around this? |
We are going to provide a new elasticsearch client at the end of 7.9. Switching to it in 7.10 would be the ideal case. |
@joshdover I can't find the issue, but did we get the server status feature into NP yet? To replace this code |
No this hasn't been completed yet, you can track this issue: #41983 |
Outdated/completed task |
Stack Monitoring migration will be a little untraditional since it will still keep angularjs in the first phase. With
configureAppAngularModule
we are able to create an angular shim until we are ready to refactor to React.Helpful links:
#31968
https://github.com/elastic/kibana/tree/master/rfcs/text
Legends:
⏳ Currently in-progress by @igoristic
Client Side docs:
7.6
Phase 1: (Part of the NP progress and is required before 8.0)
legacy.ts
, CoreSetupplugin.ts
, and startnp_ready
directory process.configureAppAngularModule
. Test original functionality still works: routing, breadcrumbs, globalState, timefilter, etc...ui/timefilter
(or possible leverage: Move timefilter and timehistory instantiation ⇒ data plugin #44783)ui/kbn_top_nav
(using Allow plugins to register top nav menu items (regression fix) #48542)plugins/monitoring/*
to their direct pathslegacy.ts
7.7
Phase 2: (This phase will not be part of the NP 8.0 progress, but will follow shortly after Phase 1)
ui/timefilter
andui/kbn_top_nav
BrowserRouter
routerglobalState
,timefilter
)np_ready
directoryServer Side docs:
7.5
Phase 1:
NOTE: Please note this list/ETAs is still work in progress and will be updated over time
The text was updated successfully, but these errors were encountered: