-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Adds support for uppercase cluster names in esdocs and other datasource bug fixes #44311
Conversation
Pinging @elastic/kibana-canvas |
7bd1aeb
to
4c4274e
Compare
retest |
💔 Build Failed |
4c4274e
to
7c4e7fb
Compare
@elasticmachine run elasticsearch-ci/docs |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice set of fixes. LGTM.
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled down the latest, followed the steps, and successfully rendered the element!
… datasource bug fixes (elastic#44311) * Sets index argument value as default index when index is not provided * Checks if default index exists before retrieving the index pattern saved object * Removed toLowerCase on index names * Removed lower casing of index names
… datasource bug fixes (elastic#44311) * Sets index argument value as default index when index is not provided * Checks if default index exists before retrieving the index pattern saved object * Removed toLowerCase on index names * Removed lower casing of index names
Summary
Closes #27099.
Closes #44135.
Closes #44141.
This fixes a few bugs surrounding default index patterns used in datasources, specifically in
esdocs
.When initially visiting the
Data
tab to configure the datasource usingElasticsearch raw documents
, theindex
argument inesdocs
will be updated in the expression to the default index instead of leaving it out of the expression.The 2nd fix resolves the error thrown by the
Data
tab when you navigate to it without having any default index pattern set by checking that a default index pattern exists before trying to retrieve the saved object from Elasticsearch.The last fix adds support for uppercase cluster names by removing
toLowerCase
transforms on index names. Every instance of the index name was lowercased because Elasticsearch doesn't allow uppercase letters in the index names, but remote clusters do allow upper case letters in the cluster names.To test support for case sensitive index names:
Install one of the sample data sets like
kibana_sample_data_ecommerce
.Go into the Kibana dev console, and run this API call to create a remote cluster
cluster_ONE
remote cluster. Here's a sample expression:Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers