-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] Add ML module setup hook #43050
[Logs UI] Add ML module setup hook #43050
Conversation
…uirement filtering check
Pinging @elastic/infra-logs-ui |
💔 Build Failed |
x-pack/legacy/plugins/infra/public/containers/logs/log_analysis/api/ml_setup_module_api.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pulling this in now to review now that the module PR is merged and I can test it. Also this comment review should make the infra-logs-ui team review request go away...
How is this hook expected to be used? Is it something like this? const [setupMlModule] = useLogAnalysisJobs();
return <button onClick={setupMlModule}>Create ML Job</button> |
@Zacqary Pretty much, yep, Behind the scenes this uses What I'd recommend is not exporting the
Just like the job status check. This will provide you with the ability to disable the save button and so on. |
It includes commits from the prior unmerged PR #42931.Summary
This sketches how the ML module setup API can be called for the log analysis module (defined in #42872) using the new overrides enabled by #42946.