-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] Create screen to set up analysis ML jobs #41877
Comments
Pinging @elastic/infra-logs-ui |
@hbharding do we have a more up-to-date mockup of the setup screen that we could include in the description? |
What should go under |
Also Time Range is a dropdown, right? What options go under there? I assume same as what you can select in the Stream but just want to confirm. |
@Zacqary no "advanced settings" needed, that's a preliminary mockup for a general feel. @hbharding do we have a more up to date mockup for this? Also, I'm not sure if we're coming out of the gate with the "field to categorize" -- @Kerry350 for 7.4 I think we should leave that out, right? Doesn't make much sense to choose that if we only show log rate which doesn't use it... but I may be missing something there. |
Here are the latest setup screen designs I can see on Figma: @jasonrhodes is correct, there's no need for "Advanced settings" in this iteration. Also no need for selecting a field to categorise, as we're only providing the log rate analysis at this stage. Infact, I don't think at this stage we need the user to configure anything - unless we wanted to let them configure the bucket span for the job, but I think we were going to always use 15 minutes as that's what the ML team recommended. It would be good to look at #43050 too. I've opened that up for review now. This is a React hook that Felix setup - it deals with all of the parameters needed to setup the new module that exists in #42872 (which is awaiting ML review). There's no need to get bogged down in that review, but it doesn't make sense to throw that work away - it can be used directly for implementation work on this ticket. This ticket should be a case of building out the UI, that connects with that React hook. To setup the module as it exists we need the |
For clarification: What I'd expect to see at this stage is basically explanatory text about what's going to happen (we're going to setup some ML jobs), and a button to explicitly confirm that action, and a blocking loading state whilst this setup is happening. |
There's a lot going on in Figma so I'm always nervous to dive in there haha. Thanks for the shots. I thought the "time range" was something the ML job needed to know how far back to consider for data or something along those lines, but is that not right? If we don't need time range than yeah, this ticket becomes a simple block of text + a button that uses the work done in #43050 to make the ML API call ... |
Ah, yes, you're right. There was two parts to this, A) how far back to consider data from and B) whether to collect data indefinitely or use an end date. These are the start dates and end dates of the datafeed when using the actual ML UI. I can't see anything in our module definition that pertains to start / end dates, so I'm not sure if by default that's set to do "from now, and indefinitely". Let me take a look in to this bit. |
@Kerry350 |
Okay, so, the The I think in terms of UI it's probably better to have an explicit |
@jgowdyelastic beat me to it 😅 |
(We could of course just use the defaults - start of index and continuously collecting data - and not add these parts to the UI to keep it even simpler. But I'm thinking this might put people off using the feature altogether if they have large indexes, or just want to glean information from a very specific point in time). |
So to clarify:
Is that about right? |
Actually I'm re-reading this and realizing we don't actually need any input fields. Should I just replace the |
Use the Figma designs, but more for inspiration than anything. We don't need to adhere to the designs 100% at the moment. And utilise EUI components as much as possible. The screen should allow you to configure an optional We should have some explanatory text about what is happening, i.e. you're setting up machine learning jobs to analyse your logs for anomalies. The button should be disabled whilst this setup takes place. Yeah, one screen will work for now. |
Are |
@Zacqary milliseconds |
Summary
The ML-based log analysis functionality (#41505) requires initial setup by the user before it can become active. The screen that contains the setup controls will be shown when the user activates the "Analysis" tab, but the ML jobs are not (yet) set up correctly.
Acceptance criteria
ml
plugin's module setup API is used to create the jobs (see [Logs UI] Create ML module for log analysis #42593 and implementation notes below).Implementation notes
ml
plugin's module setup API at/api/ml/modules/setup/:moduleId
will be enhanced by the ML team ([ML] Allow for injection of job parameters upon module setup #42409) to allow us to:Mockups
The text was updated successfully, but these errors were encountered: