[Monitoring] Clearer MB migration state on the overview page #41898

chrisronline · 2019-07-24T14:22:29Z

Resolves #41725

Instead of showing 0/1 (or something similar), let's simplify what we're showing by only showing something (a flag icon) if the user should take action on the listing page for the stack product. Also, provide a tooltip that explains this more.

Testing

Load stack monitoring
Navigate/Ensure on the /overview page
Add the setup mode flag (inSetupMode:!t) to the global state, so a valid url will look like: http://localhost:5601/app/monitoring#/overview?_g=(cluster_uuid:SckmahAJRiG_Z0R47B-J1w,inSetupMode:!t)

elasticmachine · 2019-07-24T14:22:31Z

Pinging @elastic/stack-monitoring

ycombinator · 2019-07-24T15:20:59Z

I have a 1-node ES cluster running. Initially it was using internal collection (and no Metricbeat collection). So I saw the flag on the Overview page as expected, with this message:

Some nodes are not monitored by Metricbeat. Click the flag icon to visit the nodes listing page and find out more information about the status of each node.

So I went to the nodes listing page and followed the instructions for enabling Metricbeat collection. After I did that successfully the nodes listing page told me that the Setup Status for my one and only node was:

Internal collection and Metricbeat collection

Then I came back to the Overview page (while still in Setup mode). I still see the flag and the same tooltip message. Now that all my nodes are being monitored via Metricbeat, saying that "Some nodes are not monitored by Metricbeat" seems confusing.

ycombinator · 2019-07-24T15:23:25Z

Apart from the confusing messaging on the flag tooltip when both internal collection and Metricbeat collection are setup for all ES nodes (see previous comment), I like the general idea of the flag tooltip and simpler messaging here.

I also verified that no flag shows up if the user is not in setup more OR if the user is in setup mode but all nodes are being exclusively monitored by Metricbeat.

elasticmachine · 2019-07-24T15:24:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chrisronline · 2019-07-24T15:47:58Z

@ycombinator Good point. I've updated the copy to say:

Some nodes are not monitored exclusively by Metricbeat

In the state where one or more nodes/instances are monitored by both.

WDYT?

…_setup_state

ycombinator · 2019-07-24T15:52:10Z

Consider the scenario where we have a 2-node cluster.

Node 1 is using internal collection but not Metricbeat collection.
Node 2 is using internal collection AND Metricbeat collection.

What should the tooltip message say then?

chrisronline · 2019-07-24T16:04:13Z

I'm trying to avoid this tooltip being too wordy, but maybe that's not the direction we should.

We could lay out all the cases and support longer messaging, if we think that's a better direction:

All nodes are internally monitored

All nodes are not monitored by Metricbeat.

Some nodes are fully monitored by MB, and some are internally monitored

Some nodes are monitored by Metricbeat, but some are not.

Some nodes are partially (meaning both internal and MB) monitored, and some are internally monitored

Some nodes are monitored by both Metricbeat and internal collection, and some are not monitored by Metricbeat at all.

Some nodes are partially (meaning both internal and MB) monitored, and some are monitored only by Metricbeat (for Kibana use case)

Some nodes are monitored by both Metricbeat and internal collection, and some are only monitored by Metricbeat.

We could list more probably, but is this the direction we should go?

elasticmachine · 2019-07-24T16:49:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ycombinator · 2019-07-24T16:52:04Z

Clearly what we need in the toolip is a venn diagram 😜

Jokes aside, I think we need to take a step back and decide the purpose of this tooltip. If I'm reading previous discussion correctly, I think the idea is to show this flag+tooltip if there's any setup work yet to be done, with the end goal being for all nodes to be monitored exclusively using Metricbeat. I also like the idea that the tooltip message should be simple while directing the user to see the Node Listing page for details.

So I think we only show the flag+tooltip if:

There's at least one node that isn't being monitored using Metricbeat, or
All nodes are being monitored using Metricbeat but internal collection still needs to be turned off.

When the end goal is met (all nodes are being monitored exclusively using Metricbeat), we don't show the flag+tooltip at all.

WDYT?

chrisronline · 2019-07-24T17:01:06Z

Yup, agreed.

We still need to decide on the copy for the tooltip.

There's at least one node that isn't being monitored using Metricbeat

Not all nodes are exclusively monitored by Metricbeat.

All nodes are being monitored using Metricbeat but internal collection still needs to be turned off.

All nodes are exclusively monitored by Metricbeat, but internal collection needs to be disabled.

WDYT?

chrisronline · 2019-07-24T17:05:21Z

Or maybe more like the earlier examples for the first one:
Some nodes are not exclusively monitored by Metricbeat.

ycombinator · 2019-07-24T17:06:22Z

All nodes are exclusively monitored by Metricbeat, but internal collection needs to be disabled.

This statement cannot be true 😄. If all nodes are exclusively monitored by Metricbeat, it follows that internal collection is disabled.

I wasn't at all clear in my previous comment but the two bullets I posted were also meant to be the copy for the tooltip (pending any cleanup in the future by @gchaps, of course). I'll repost them below:

There's at least one node that isn't being monitored using Metricbeat. Click...
All nodes are being monitored using Metricbeat but internal collection still needs to be turned off. Click...

ycombinator · 2019-07-24T17:09:33Z

@chrisronline To move this PR forward, I'm happy with whatever copy you like as long as we're in agreement about the two conditions under which we should show the flag+tooltip. @gchaps will probably have to clean it up later anyway.

chrisronline · 2019-07-24T17:36:37Z

I'm happy with what you suggested. Code is updated now and ready for 👀

elasticmachine · 2019-07-24T18:28:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ycombinator · 2019-07-25T14:19:02Z

When all nodes are being monitored by both Metricbeat and internal collection, the tooltip message looks like this:

In this state, the last sentence doesn't really make sense for the user IMO, particularly this bit:

... and find out more information about the status of each node.

Would it be possible to say something like this instead?

... and disable internal collection.

(I'm using "disable" instead of "turn off" only because the button on the Node Listing page is titled "Disable and finish migration".)

ycombinator · 2019-07-25T14:25:48Z

Once I completely finished my ES cluster migration to Metricbeat monitoring and went back to the Overview page, while still in Setup Mode, I noticed that the flag icon has disappeared. Effectively this page now looks the same as if the user was not in Setup Mode.

I wonder if we should show a banner (or some other UI treatment) telling the user that they are in Setup Mode? With a banner we could also provide a link for them to exit Setup Mode. [EDIT] This would be part of a separate PR, of course, but:

Another idea, perhaps in addition to the banner, would be to replace the flag icon with a checkmark icon when the setup looks good? Hovering over it could basically just tell the user exactly that but in a couple of sentences, like:

All nodes are being monitored using Metricbeat. Your Elasticsearch monitoring setup looks good!

(Again, I expect the language to get cleaned up later by @gchaps, of course).

chrisronline · 2019-07-25T15:00:15Z

I wonder if we should show a banner (or some other UI treatment) telling the user that they are in Setup Mode? With a banner we could also provide a link for them to exit Setup Mode.

Yup, this is a good point but we already plan to add something like this in Step 5

ycombinator · 2019-07-25T15:04:36Z

@chrisronline Understood re: step 5, but WDYT about the rest of my comment?

Another idea, perhaps in addition to the banner, would be to...

chrisronline · 2019-07-25T15:09:23Z

Would it be possible to say something like this instead?

Agreed, that's better. I've updated the PR with this change

chrisronline · 2019-07-25T15:11:16Z

Another idea, perhaps in addition to the banner, would be to replace the flag icon with a checkmark icon when the setup is completed? Hovering over it could basically just tell the user exactly that but in a couple of sentences,

Originally, the plan was to have an icon indicating they need to take action, or an icon indicating they didn't need to take action. After talking it over with @cchaos, we decided that it might be better to limit the number of icons in the UI and only present ones when the user needs to do something. I do think we need some kind of general indicator of setup mode status, but I'm not sure we need a specific icon indicating each stack product is setup correctly. I could probably go either way, and my decision in this PR was heavily swayed by thoughts from @cchaos

ycombinator · 2019-07-25T15:26:37Z

@chrisronline Thanks for clarifying. I'm good with the direction you agreed upon previously with @cchaos.

ycombinator

LGTM.

elasticmachine · 2019-07-25T16:16:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chrisronline · 2019-07-25T16:42:27Z

retest

elasticmachine · 2019-07-25T17:42:10Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…_setup_state

elasticmachine · 2019-07-26T17:04:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

igoristic · 2019-07-31T18:18:09Z

LGTM 👍

elasticmachine · 2019-07-31T19:33:14Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…#42462) * Just show an icon if action is necessary, otherwise show nothing * Update copy * Update copy based on state * Updated logic and copy * Update copy

chrisronline · 2019-08-01T18:44:09Z

Backport:

7.x: 9441a86

Just show an icon if action is necessary, otherwise show nothing

adf617b

chrisronline added review Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Jul 24, 2019

chrisronline requested review from ycombinator and igoristic July 24, 2019 14:22

chrisronline self-assigned this Jul 24, 2019

chrisronline mentioned this pull request Jul 24, 2019

[Setup UI] Distinguish between setup states #41725

Closed

Update copy

6bb2e67

ycombinator mentioned this pull request Jul 24, 2019

Implement a UI within Stack Monitoring to help users migrate to MB shipping/collecting #39010

Closed

5 tasks

chrisronline mentioned this pull request Jul 24, 2019

[Monitoring] Metricbeat migration for logstash, beats and apm #40442

Merged

Update copy based on state

2b035f2

Merge remote-tracking branch 'elastic/master' into monitoring/clearer…

7b07182

…_setup_state

Updated logic and copy

31067d9

Update copy

1e29eae

Merge in master

61c6452

ycombinator approved these changes Jul 25, 2019

View reviewed changes

Merge remote-tracking branch 'elastic/master' into monitoring/clearer…

f918b17

…_setup_state

igoristic approved these changes Jul 31, 2019

View reviewed changes

Merge in master

dd1ab89

chrisronline merged commit 976d976 into elastic:master Jul 31, 2019

chrisronline deleted the monitoring/clearer_setup_state branch July 31, 2019 20:24

This was referenced Jul 31, 2019

[7.x] [Monitoring] Clearer MB migration state on the overview page (#41898) #42396

Closed

[7.x] [Monitoring] Clearer MB migration state on the overview page (#41898) #42462

Merged

chrisronline mentioned this pull request Aug 6, 2019

[Monitoring] Metricbeat migration improvements #42600

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Monitoring] Clearer MB migration state on the overview page #41898

[Monitoring] Clearer MB migration state on the overview page #41898

chrisronline commented Jul 24, 2019

elasticmachine commented Jul 24, 2019

ycombinator commented Jul 24, 2019

ycombinator commented Jul 24, 2019

elasticmachine commented Jul 24, 2019

chrisronline commented Jul 24, 2019

ycombinator commented Jul 24, 2019

chrisronline commented Jul 24, 2019

elasticmachine commented Jul 24, 2019

ycombinator commented Jul 24, 2019

chrisronline commented Jul 24, 2019

chrisronline commented Jul 24, 2019

ycombinator commented Jul 24, 2019 •

edited

Loading

ycombinator commented Jul 24, 2019

chrisronline commented Jul 24, 2019

elasticmachine commented Jul 24, 2019

ycombinator commented Jul 25, 2019 •

edited

Loading

ycombinator commented Jul 25, 2019 •

edited

Loading

chrisronline commented Jul 25, 2019

ycombinator commented Jul 25, 2019

chrisronline commented Jul 25, 2019

chrisronline commented Jul 25, 2019

ycombinator commented Jul 25, 2019

ycombinator left a comment

elasticmachine commented Jul 25, 2019

chrisronline commented Jul 25, 2019

elasticmachine commented Jul 25, 2019

elasticmachine commented Jul 26, 2019

igoristic commented Jul 31, 2019

elasticmachine commented Jul 31, 2019

chrisronline commented Aug 1, 2019

[Monitoring] Clearer MB migration state on the overview page #41898

[Monitoring] Clearer MB migration state on the overview page #41898

Conversation

chrisronline commented Jul 24, 2019

Testing

elasticmachine commented Jul 24, 2019

ycombinator commented Jul 24, 2019

ycombinator commented Jul 24, 2019

elasticmachine commented Jul 24, 2019

💔 Build Failed

chrisronline commented Jul 24, 2019

ycombinator commented Jul 24, 2019

chrisronline commented Jul 24, 2019

All nodes are internally monitored

Some nodes are fully monitored by MB, and some are internally monitored

Some nodes are partially (meaning both internal and MB) monitored, and some are internally monitored

Some nodes are partially (meaning both internal and MB) monitored, and some are monitored only by Metricbeat (for Kibana use case)

elasticmachine commented Jul 24, 2019

💚 Build Succeeded

ycombinator commented Jul 24, 2019

chrisronline commented Jul 24, 2019

chrisronline commented Jul 24, 2019

ycombinator commented Jul 24, 2019 • edited Loading

ycombinator commented Jul 24, 2019

chrisronline commented Jul 24, 2019

elasticmachine commented Jul 24, 2019

💚 Build Succeeded

ycombinator commented Jul 25, 2019 • edited Loading

ycombinator commented Jul 25, 2019 • edited Loading

chrisronline commented Jul 25, 2019

ycombinator commented Jul 25, 2019

chrisronline commented Jul 25, 2019

chrisronline commented Jul 25, 2019

ycombinator commented Jul 25, 2019

ycombinator left a comment

Choose a reason for hiding this comment

elasticmachine commented Jul 25, 2019

💔 Build Failed

chrisronline commented Jul 25, 2019

elasticmachine commented Jul 25, 2019

💔 Build Failed

elasticmachine commented Jul 26, 2019

💚 Build Succeeded

igoristic commented Jul 31, 2019

elasticmachine commented Jul 31, 2019

💚 Build Succeeded

chrisronline commented Aug 1, 2019

ycombinator commented Jul 24, 2019 •

edited

Loading

ycombinator commented Jul 25, 2019 •

edited

Loading

ycombinator commented Jul 25, 2019 •

edited

Loading