-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Setup UI] Distinguish between setup states #41725
Comments
Pinging @elastic/stack-monitoring |
I agree completely. +1 on setting this to 1/1 and changing the background color to something like yellow, at a minimum. |
I agree with showing 1/1 |
I believe a grammatical change is necessary for the second tooltip. The second sentence currently reads, I propose that this be changed to: This better correlates the word |
Also, should one need to click |
Sure, we can make those changes. Do you think, with those changes, the overall UX is better/well understood? Or should we go another direction? |
@chrisronline That's a good question. My initial reaction, to be honest, is to say that we can improve this though I'm not (yet) certain how. Let me try to elaborate on my concerns. I think that as it sits, it's necessary to hover over the colored boxes and then to read each tooltip in order to know what they are at all. This means of interacting with them feels just sort of initially confusing. Perhaps if they had a title alongside or above indicating their purpose this could be made easier to understand at first glance? |
@chrisronline Red and Yellow have a meaning of Error and Warning. Do you regard to native local collection as an error? Do you see double monitoring as a concern? Is it only when we see the metricbeat reports locally? |
Thanks for the feedback all! I chatted with @cchaos (thanks again!) and we talked through a potentially simpler solution. I think the sole purpose of any UI changes on this page is to inform the user they might need to take action in the relevant listing page. We mine as well just show one of two states:
WDYT? |
👍 My only concern is the "Click for more information" text. If you're just taking them to the Nodes listing page it won't be obvious as to what information they should be looking for. I'd suggest something more descriptive like "Click the flag icon to visit the Nodes listing page and select those you with to migrate"... or something. Maybe get with @gchaps over language. |
I like this UX |
@cchaos I've updated the copy to:
I'll make sure to consult with @gchaps on the final PR (which isn't up yet) to iron out any and all copy issues |
EDIT: This is not longer true. Changes are in this PR: #41725 (comment) |
I like it. My only question is consistency throughout Kibana (and the Stack Monitoring application). Is the flag in use anywhere currently? If so, are there examples we can see? (This is probably a question for @cchaos ) If this is the first use of the icon, will it be reserved for this kind of informational use going forward or is it subject to change? I'm just hoping that we can ensure that it doesn't mean something in the Stack Monitoring application and something dramatically different somewhere else. :) Other than that, 👍 |
PR up for these changes for Kibana and ES (as the beats/logstash/apm changes are not in master yet): #41898 |
@cachedout Fair point. I didn't decide on the icon myself, so I'll let @cchaos weigh in. AFAIK, we don't use this icon anywhere in monitoring currently. |
It's really up to the app owners to place meaning on individual icons. Flags are usually just used as general indicators of something that needs attention. |
Thanks @cchaos I think we're in a safe position to start using the flag icon, as it's a little different than the alert icon (which we use in the cluster alerts UI). Any issues moving forward with this, @cachedout (or anyone else)? |
👍 from me |
I'm running a cluster that's using internal collection for monitoring. Here's what the cluster's overview page looks like in setup mode:
Notice the
0/1
with the danger background. And also notice the tooltip text suggesting that the 1 node doesn't have monitoring setup. However, monitoring is setup; it's just not Metricbeat-based.I wonder if we should change the counts (to be
1/1
in this example), background color, and/or tooltip text to indicate the setup state more clearly in this scenario?The text was updated successfully, but these errors were encountered: