Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs/Reporting] More information about HTTP / script stuff #41200

Merged
merged 12 commits into from
Jul 18, 2019

Conversation

tsullivan
Copy link
Member

Follows #40931

This moves text from an important note to its own section: HTTP Response Codes:

image

@tsullivan tsullivan added review Team:Docs (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app


- **`200` (OK)**: As expected, Kibana returns `200` status in the response for
successful requests to queue or download reports.
+
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: easy-to-miss soft line break here


If there was an error in generating the report, the download URL will return a 500
(Internal Server Error) response. More information is available in the
Reporting management page in Kibana: *Management > Kibana > Reporting*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this is moved to a standalone section, because it grew pretty large

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

docs/reporting/response-codes.asciidoc Outdated Show resolved Hide resolved

- **`503` (Service Unavailable)**: When using the `path` to request the download, you will get
a `503` status response if report generation hasn't completed yet. In that case,
retry after the number of seconds in the `Retry-After` header in the download API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is confusing:

In that case, retry after the number of seconds in the Retry-After header in the download API response until the report is complete.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean. How about:

When using the path to request the download, you will get a 503 status response if report generation hasn't completed yet. A 503 response comes with a Retry-After header. Before trying again to download the report, you can have your script wait the suggested number of seconds found in the Retry-After header until the report is complete.

docs/reporting/response-codes.asciidoc Outdated Show resolved Hide resolved
docs/reporting/script-example.asciidoc Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tsullivan tsullivan merged commit b2cd01e into elastic:master Jul 18, 2019
@tsullivan tsullivan deleted the docs/reporting-post-url branch July 18, 2019 21:41
tsullivan added a commit to tsullivan/kibana that referenced this pull request Jul 18, 2019
…41200)

* [Docs/Reporting] More information about HTTP / script stuff

* "post url" formatting consistency

* consistent wording from 1 paragraph to another

* Update docs/reporting/response-codes.asciidoc

Co-Authored-By: gchaps <[email protected]>

* pr feedback

* subs=attributes, version in command example

* "Retry-After" content

* another feedback
tsullivan added a commit to tsullivan/kibana that referenced this pull request Jul 18, 2019
…41200)

* [Docs/Reporting] More information about HTTP / script stuff

* "post url" formatting consistency

* consistent wording from 1 paragraph to another

* Update docs/reporting/response-codes.asciidoc

Co-Authored-By: gchaps <[email protected]>

* pr feedback

* subs=attributes, version in command example

* "Retry-After" content

* another feedback
tsullivan added a commit to tsullivan/kibana that referenced this pull request Jul 18, 2019
…41200)

* [Docs/Reporting] More information about HTTP / script stuff

* "post url" formatting consistency

* consistent wording from 1 paragraph to another

* Update docs/reporting/response-codes.asciidoc

Co-Authored-By: gchaps <[email protected]>

* pr feedback

* subs=attributes, version in command example

* "Retry-After" content

* another feedback
tsullivan added a commit that referenced this pull request Jul 18, 2019
…41523)

* [Docs/Reporting] More information about HTTP / script stuff

* "post url" formatting consistency

* consistent wording from 1 paragraph to another

* Update docs/reporting/response-codes.asciidoc

Co-Authored-By: gchaps <[email protected]>

* pr feedback

* subs=attributes, version in command example

* "Retry-After" content

* another feedback
tsullivan added a commit that referenced this pull request Jul 18, 2019
…41524)

* [Docs/Reporting] More information about HTTP / script stuff

* "post url" formatting consistency

* consistent wording from 1 paragraph to another

* Update docs/reporting/response-codes.asciidoc

Co-Authored-By: gchaps <[email protected]>

* pr feedback

* subs=attributes, version in command example

* "Retry-After" content

* another feedback
tsullivan added a commit that referenced this pull request Jul 18, 2019
…41525)

* [Docs/Reporting] More information about HTTP / script stuff

* "post url" formatting consistency

* consistent wording from 1 paragraph to another

* Update docs/reporting/response-codes.asciidoc

Co-Authored-By: gchaps <[email protected]>

* pr feedback

* subs=attributes, version in command example

* "Retry-After" content

* another feedback
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes review Team:Docs Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants