Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs/Reporting] Improve docs on automating Reporting #40931

Merged
merged 8 commits into from
Jul 15, 2019

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Jul 11, 2019

Summary

Closes:

Addresses:

Improve documentation on how to automate Kibana Reporting, with Watcher and with a custom script.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

Screenshot

image

@tsullivan tsullivan added v7.2.0 v7.3.0 v7.4.0 v8.0.0 (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead review labels Jul 11, 2019
include::report-intervals.asciidoc[]

To get the URL for triggering a report generation during a given time period:
[float]
=== Getting the POST URL
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entirely new section to talk about what is the POST URL


To configure a watch to email reports, you use the `reporting` attachment type
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to watch-example


[float]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lack of this [float] caused this section to be its own page, which seemed wrong

@@ -18,7 +25,7 @@ PUT _watcher/watch/error_report
"attachments" : {
"error_report.pdf" : {
"reporting" : {
"url": "http://0.0.0.0:5601/api/reporting/generate/dashboard/Error-Monitoring?_g=(time:(from:now-1d%2Fd,mode:quick,to:now))", <2>
"url": "http://0.0.0.0:5601/api/reporting/generate/printablePdf?jobParams=...", <2>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report from the Kibana UI.
<3> Optional, default is 40
<4> Optional, default is 15s
<5> Provide user credentials for a user with permission to access Kibana and
{reporting}.
//For more information, see <<secure-reporting>>.
//<<reporting-app-users, Setting up a Reporting Role>>.

NOTE: Reporting is integrated with Watcher only as an email attachment type.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new NOTE I felt it important to mention


If there was an error in generating the report, the download URL will return a 500
(Internal Server Error) response. More information will be available in the the
Reporting management page in Kibana: *Management > Kibana > Reporting*
Copy link
Member Author

@tsullivan tsullivan Jul 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info about 503 was pre-existing. Info about the 500 is new

Wrapping this in IMPORTANT is also new

@elasticmachine
Copy link
Contributor

💔 Build Failed

docs/reporting/automating-report-generation.asciidoc Outdated Show resolved Hide resolved
docs/reporting/script-example.asciidoc Outdated Show resolved Hide resolved
docs/reporting/script-example.asciidoc Outdated Show resolved Hide resolved

[float]
== Deprecated Report URLs

The following is deprecated in 6.0, and you should now use {kib} to get the URL for a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear "the following is deprecated" refers to.

Copy link
Member Author

@tsullivan tsullivan Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about:

The following POST URL paths were once supported but are now deprecated. If there are any problems with using these paths after upgrading Kibana's version, you should use {kib} to re-generate the POST URL for a particular report.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's much better.

@joelgriffith
Copy link
Contributor

This is awesome!

@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Jul 12, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section regarding CSV reports looks terrific! I'm on support dev ramp this week so I don't have time to review the rest of the PR unfortunately. Thank you for doing this, Tim!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tsullivan tsullivan force-pushed the docs/reporting-post-url branch from ba6b15c to 6dced7c Compare July 15, 2019 19:51
@tsullivan
Copy link
Member Author

I started making more changes about what can cause the 400 status. But since this PR has enough LGTMs, I then backed out those last changes. Going to merge this as it was when it got the LGTM.

@tsullivan tsullivan merged commit e24440e into elastic:master Jul 15, 2019
@tsullivan tsullivan deleted the docs/reporting-post-url branch July 15, 2019 19:53
tsullivan added a commit to tsullivan/kibana that referenced this pull request Jul 15, 2019
* [Docs/Reporting] Improve docs on automating Reporting

* Update docs/reporting/automating-report-generation.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* --wip-- [skip ci]

* word change
tsullivan added a commit to tsullivan/kibana that referenced this pull request Jul 15, 2019
* [Docs/Reporting] Improve docs on automating Reporting

* Update docs/reporting/automating-report-generation.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* --wip-- [skip ci]

* word change
tsullivan added a commit to tsullivan/kibana that referenced this pull request Jul 15, 2019
* [Docs/Reporting] Improve docs on automating Reporting

* Update docs/reporting/automating-report-generation.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* --wip-- [skip ci]

* word change
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tsullivan
Copy link
Member Author

@lcawl You let me know that you added a followup fix to master. As you requested, I cherry picked it into each of the backport branches:

7.x/7.4: #41179
7.3: #41180
7.2: #41181

tsullivan added a commit that referenced this pull request Jul 15, 2019
…41179)

* [Docs/Reporting] Improve docs on automating Reporting (#40931)

* [Docs/Reporting] Improve docs on automating Reporting

* Update docs/reporting/automating-report-generation.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* --wip-- [skip ci]

* word change

* [DOCS] Fixes broken reporting links (#41195)
tsullivan added a commit that referenced this pull request Jul 15, 2019
…41180)

* [Docs/Reporting] Improve docs on automating Reporting (#40931)

* [Docs/Reporting] Improve docs on automating Reporting

* Update docs/reporting/automating-report-generation.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* --wip-- [skip ci]

* word change

* [DOCS] Fixes broken reporting links (#41195)
tsullivan added a commit that referenced this pull request Jul 15, 2019
…41181)

* [Docs/Reporting] Improve docs on automating Reporting (#40931)

* [Docs/Reporting] Improve docs on automating Reporting

* Update docs/reporting/automating-report-generation.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/reporting/script-example.asciidoc

Co-Authored-By: gchaps <[email protected]>

* --wip-- [skip ci]

* word change

* [DOCS] Fixes broken reporting links (#41195)
@lcawl
Copy link
Contributor

lcawl commented Jul 15, 2019

Thanks @tsullivan !

@renshuki
Copy link
Contributor

renshuki commented Mar 3, 2020

@tsullivan @lcawl does it make sense to backport this to 6.8 as well with minor changes (like kbn-version header)? I don't see anything feature specific to 7.x and I think this is expecting to work on 6.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes review v7.2.0 v7.3.0 v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants