Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Fix PDF generation #39418

Merged
merged 2 commits into from
Jun 25, 2019
Merged

[Canvas] Fix PDF generation #39418

merged 2 commits into from
Jun 25, 2019

Conversation

clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Jun 21, 2019 •
edited
Loading

Closes #39417

PDFs aren't being produced because the props for ExportApp aren't up-to-date.

While this PR fixes some workpads, my Elastic{ON} Austin talk is still broken with a vague error:

server    log   [18:02:09.937] [error][browser-driver][chromium-driver-factory][headless-chromium-driver][reporting] waitForSelector .application failed on http://localhost:5603/zey/app/canvas

@clintandrewhall clintandrewhall added loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.3.0 impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Jun 21, 2019
@clintandrewhall clintandrewhall requested a review from monfera June 21, 2019 00:03
@clintandrewhall clintandrewhall added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jun 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@clintandrewhall
Copy link
Contributor Author

So it appears this is a limitation of Kibana and the number of pages you can pass at one time. So this should fix the problem for workpads.

@clintandrewhall clintandrewhall marked this pull request as ready for review June 21, 2019 00:38
@clintandrewhall clintandrewhall requested a review from a team as a code owner June 21, 2019 00:38
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

monfera
monfera approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@monfera monfera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great 🎉

image

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@clintandrewhall clintandrewhall merged commit 1d09f5a into elastic:master Jun 25, 2019
@clintandrewhall clintandrewhall mentioned this pull request Jun 25, 2019
Merged
clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Jun 25, 2019
@clintandrewhall
Fix PDF generation in Canvas (elastic#39418)
9838f16
clintandrewhall added a commit that referenced this pull request Jun 26, 2019
@clintandrewhall
Fix PDF generation in Canvas (#39418) (#39600)
78dc343
@shaunmcgough shaunmcgough mentioned this pull request Aug 1, 2019
Closed
@clintandrewhall clintandrewhall deleted the pdf-fix branch August 30, 2019 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monfera monfera monfera approved these changes

Assignees
No one assigned
Labels
impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.3.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Canvas] PDF Generation consistently fails
3 participants
@clintandrewhall @elasticmachine @monfera