Spaces - Copy Saved Objects to Spaces UI #39002

legrego · 2019-06-14T17:33:52Z

Summary

This introduces a new "Copy to space" action within the Saved Objects Management UI. When Spaces is enabled, a new action appears in the table next to each saved object. From there, users are given the option to copy that saved object (with or without references) to one or more other spaces.

Tasks

create workflow
create integration points in saved objects management ui
integrate with actual APIs from Copy Saved Objects to Spaces API #38014
testing
i18n verification
a11y verification
copy review

Menu option

Select spaces to copy into

Processing copy

Copy response, showing sample error

Copy response, showing conflict resolution

Resolves #37286

"Release notes: Saved objects can be easily copied from one space to another from the Saved Objects Management screen"

legrego · 2019-06-14T17:35:20Z

@cchaos no rush, as the implementation is blocked on several other PRs, but if you get some free time, I'd love a preliminary design review!

elasticmachine · 2019-06-14T17:35:42Z

Pinging @elastic/kibana-security

legrego · 2019-06-14T17:39:39Z

src/legacy/ui/public/management/saved_objects_management/saved_objects_management_action.ts

+  };
+}
+
+export abstract class SavedObjectsManagementAction<T = unknown> {


This is tightly coupled to both EUI and React. My ultimate goal is to replace this entirely with the Embeddable/Actions APIs once they're ready, so I don't want to spend a ton of time crafting the perfect abstraction here. Instead, this provides enough functionality to enable the copy-to-space feature, without coupling it to Spaces itself.

elasticmachine · 2019-06-14T18:31:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

^ Unrelated CI failure

src/legacy/ui/public/management/saved_objects_management/saved_objects_management_action.ts

elasticmachine · 2019-06-25T20:11:32Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-03T13:23:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-08T19:58:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

Conky5 · 2019-07-08T20:34:41Z

retest

elasticmachine · 2019-07-08T21:36:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cchaos · 2019-07-15T18:01:05Z

@legrego Sorry it's taken so long for the design team to take a look at this. @ryankeairns will actually be able to help you out on it. You'll probably want to sync with him to go over the purpose and intricacies of all the Spaces stuffs.

legrego · 2019-08-23T02:14:42Z

We also are re-using types and processImportResponse from the saved objects import, which is somewhat awkward. It isn't obvious that internally copy to space is relying upon import/export.

I didn't see it that way - I liked that we weren't duplicating functionality or type definitions for what's effectively a thin wrapper around the import/export feature. It felt to me like we'd be able to see how changes to import/export will impact Copy to Space in the future. Do you have suggestions on how we can improve this? We can divorce the two from a types perspective, but then I feel like it's even less obvious that copy to space relies upon import/export.

Also, when choosing to "overwrite" a saved object, should we change the test of the "Finish" button? It wasn't immediately obvious to me that clicking "overwrite" wasn't enough to actually overwrite it and that we were just marking it to be retried once we hit "Finish".

Sure, that's a good idea.

elasticmachine · 2019-08-23T12:38:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

legrego · 2019-08-23T16:08:33Z

Following a discussion with @kobelb, we decided on the following:

We will no longer explain when a copy failed due to "missing references"
We will no longer allow a saved object to be copied without it's references (related objects)

These decisions were made after discovering shortcomings in the import/export functionality which would have led to a confusing user experience for the Copy to Space feature.

legrego · 2019-08-23T16:18:20Z

Also discovered during testing: #43876

kobelb

LGTM on green CI

snide · 2019-08-23T17:02:06Z

@legrego I'll have a review / PR for you in a couple hours from the design side.

elasticmachine · 2019-08-23T17:21:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

snide

I loaded this locally and looked through the code. There are some changes I'd like to make on the design / sass side that I can do on my own. There's nothing in here that looks scary that I would want to hold this PR up for.

Since we're got the green, I'm ok with a merge, and I'll do my design pass as a separate concern before freeze.

elasticmachine · 2019-08-23T20:57:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

sample UI for copying a single object to multiple spaces

e0aca37

legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Spaces Platform Security - Spaces feature WIP Work in progress labels Jun 14, 2019

legrego commented Jun 14, 2019

View reviewed changes

legrego commented Jun 17, 2019

View reviewed changes

src/legacy/ui/public/management/saved_objects_management/saved_objects_management_action.ts Outdated Show resolved Hide resolved

legrego added 3 commits June 25, 2019 13:53

Simplify action

933817e

Merge branch 'master' of github.com:elastic/kibana into copy-to-space-ui

8401fee

fix merge from master

46a68df

legrego added 4 commits June 27, 2019 11:25

WIP status indicator

d33e73d

POC conflict resolution UI

c07f905

prefix exported types with SavedObjects

e27e111

Merge branch 'master' of github.com:elastic/kibana into copy-to-space-ui

29f2bdc

show finish button

4b18c51

legrego added 6 commits July 30, 2019 16:44

adopting design's mockup

61491ff

Merge branch 'master' of github.com:elastic/kibana into copy-to-space-ui

a1b662e

enabling conflict resolution, and other improvements

8e00c79

move inline styles to sass

8c4425b

ux adjustments

bea29e3

add loading indicator

92edadc

legrego added 3 commits August 22, 2019 21:50

reorganize types; type SpaecsManager CTS functions

0d62721

transient => transitive

9beea0c

removing incorrect union type (null)

56f949d

legrego added 6 commits August 23, 2019 06:46

using spaces manager to retrieve the list of available spaces

fcf1870

removing unnecessary useEffect

189f872

removing cts_ prefix

e615838

improved button text when resolving conflicts

917fc63

test updates

2fe0e21

Merge branch 'master' of github.com:elastic/kibana into copy-to-space-ui

09ba89e

legrego added 2 commits August 23, 2019 11:37

remove 'missing references' functionality

5f1cde4

require related objects to be included

65e3594

kobelb approved these changes Aug 23, 2019

View reviewed changes

snide self-requested a review August 23, 2019 17:02

snide approved these changes Aug 23, 2019

View reviewed changes

legrego merged commit 6a9844c into elastic:master Aug 23, 2019

legrego deleted the copy-to-space-ui branch August 23, 2019 18:24

legrego mentioned this pull request Aug 23, 2019

[7.x] Spaces - Copy Saved Objects to Spaces UI (#39002) #43888

Merged

legrego added a commit to legrego/kibana that referenced this pull request Aug 23, 2019

Spaces - Copy Saved Objects to Spaces UI (elastic#39002)

efcdb63

legrego added a commit that referenced this pull request Aug 23, 2019

Spaces - Copy Saved Objects to Spaces UI (#39002) (#43888)

85522c6

legrego mentioned this pull request Aug 26, 2019

Spaces - copy saved objects should allow copying without references #43985

Closed

peterschretlen mentioned this pull request Sep 25, 2019

Stack Monitoring + Kibana Alerting #45571

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spaces - Copy Saved Objects to Spaces UI #39002

Spaces - Copy Saved Objects to Spaces UI #39002

legrego commented Jun 14, 2019 •

edited

Loading

legrego commented Jun 14, 2019

elasticmachine commented Jun 14, 2019

legrego Jun 14, 2019

elasticmachine commented Jun 14, 2019 •

edited by legrego

Loading

elasticmachine commented Jun 25, 2019

elasticmachine commented Jul 3, 2019

elasticmachine commented Jul 8, 2019

Conky5 commented Jul 8, 2019

elasticmachine commented Jul 8, 2019

cchaos commented Jul 15, 2019

legrego commented Aug 23, 2019

elasticmachine commented Aug 23, 2019

legrego commented Aug 23, 2019

legrego commented Aug 23, 2019

kobelb left a comment

snide commented Aug 23, 2019

elasticmachine commented Aug 23, 2019

snide left a comment

elasticmachine commented Aug 23, 2019

Spaces - Copy Saved Objects to Spaces UI #39002

Spaces - Copy Saved Objects to Spaces UI #39002

Conversation

legrego commented Jun 14, 2019 • edited Loading

Summary

Tasks

Menu option

Select spaces to copy into

Processing copy

Copy response, showing sample error

Copy response, showing conflict resolution

legrego commented Jun 14, 2019

elasticmachine commented Jun 14, 2019

legrego Jun 14, 2019

Choose a reason for hiding this comment

elasticmachine commented Jun 14, 2019 • edited by legrego Loading

💔 Build Failed

elasticmachine commented Jun 25, 2019

💔 Build Failed

elasticmachine commented Jul 3, 2019

💔 Build Failed

elasticmachine commented Jul 8, 2019

💔 Build Failed

Conky5 commented Jul 8, 2019

elasticmachine commented Jul 8, 2019

💔 Build Failed

cchaos commented Jul 15, 2019

legrego commented Aug 23, 2019

elasticmachine commented Aug 23, 2019

💚 Build Succeeded

legrego commented Aug 23, 2019

legrego commented Aug 23, 2019

kobelb left a comment

Choose a reason for hiding this comment

snide commented Aug 23, 2019

elasticmachine commented Aug 23, 2019

💚 Build Succeeded

snide left a comment

Choose a reason for hiding this comment

elasticmachine commented Aug 23, 2019

💚 Build Succeeded

legrego commented Jun 14, 2019 •

edited

Loading

elasticmachine commented Jun 14, 2019 •

edited by legrego

Loading