Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip OOID tests #36944

Merged
merged 1 commit into from
May 23, 2019
Merged

Skip OOID tests #36944

merged 1 commit into from
May 23, 2019

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented May 22, 2019

rp.client_secret is now required to be in the keystore. These tests need to be skipped
until we can facilitate a means for the functional test runner/kbn-es to store settings
securely.

Related to: elastic/elasticsearch#42256

@tylersmalley tylersmalley added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 skipped-test release_note:skip Skip the PR/issue when compiling release notes v7.2.0 v7.3.0 labels May 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rp.client_secret is now required to be in the keystore. These tests need skipped
until we can facilitate a means for the functional test runner to store settings
securely.

Signed-off-by: Tyler Smalley <[email protected]>
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@tylersmalley
Copy link
Contributor Author

retest

@tylersmalley
Copy link
Contributor Author

Failure is un-related.

@tylersmalley tylersmalley merged commit fcea501 into master May 23, 2019
@tylersmalley tylersmalley deleted the skip-ooid branch May 23, 2019 03:45
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request May 23, 2019
rp.client_secret is now required to be in the keystore. These tests need skipped
until we can facilitate a means for the functional test runner to store settings
securely.

Signed-off-by: Tyler Smalley <[email protected]>
This was referenced May 23, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

tylersmalley pushed a commit that referenced this pull request May 23, 2019
rp.client_secret is now required to be in the keystore. These tests need skipped
until we can facilitate a means for the functional test runner to store settings
securely.

Signed-off-by: Tyler Smalley <[email protected]>
@tylersmalley
Copy link
Contributor Author

For 7.x, this was backported as part of #36923 since it was required for the bump and change to source builds.

@tylersmalley
Copy link
Contributor Author

7.x/7.3: 2e1655a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes skipped-test Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.2.0 v7.3.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants