-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip OOID tests #36944
Merged
Merged
Skip OOID tests #36944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
added
Team:Security
Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
v8.0.0
skipped-test
release_note:skip
Skip the PR/issue when compiling release notes
v7.2.0
v7.3.0
labels
May 22, 2019
Pinging @elastic/kibana-security |
spalger
approved these changes
May 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rp.client_secret is now required to be in the keystore. These tests need skipped until we can facilitate a means for the functional test runner to store settings securely. Signed-off-by: Tyler Smalley <[email protected]>
💚 Build Succeeded |
💔 Build Failed |
retest |
Failure is un-related. |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
May 23, 2019
rp.client_secret is now required to be in the keystore. These tests need skipped until we can facilitate a means for the functional test runner to store settings securely. Signed-off-by: Tyler Smalley <[email protected]>
This was referenced May 23, 2019
Closed
💚 Build Succeeded |
tylersmalley
pushed a commit
that referenced
this pull request
May 23, 2019
rp.client_secret is now required to be in the keystore. These tests need skipped until we can facilitate a means for the functional test runner to store settings securely. Signed-off-by: Tyler Smalley <[email protected]>
For 7.x, this was backported as part of #36923 since it was required for the bump and change to source builds. |
7.x/7.3: 2e1655a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
skipped-test
Team:Security
Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
v7.2.0
v7.3.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rp.client_secret is now required to be in the keystore. These tests need to be skipped
until we can facilitate a means for the functional test runner/kbn-es to store settings
securely.
Related to: elastic/elasticsearch#42256