Fail early when rp.client_secret is missing in OIDC realm #42256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client_secret is a required secure setting. Make sure we fail with a SettingsException and a clear, actionable message when bulding the realm, if the setting is missing.
jkakavas
added
>non-issue
:Security/Authentication
|
Pinging @elastic/es-security |
|
@elasticmachine run elasticsearch-ci/1 elasticsearch-ci/bwc elasticsearch-ci/default-distro |
|
@elasticmachine run elasticsearch-ci/bwc |
|
@elasticmachine run elasticsearch-ci/default-distro |
|
|
@elasticmachine run elasticsearch-ci/packaging-sample |
jkakavas
commented
May 21, 2019
| @@ -52,8 +53,11 @@ protected Settings nodeSettings(int nodeOrdinal) { | |||
| final Path jwkSet = createTempFile("jwkset", "json"); | |||
| OpenIdConnectTestCase.writeJwkSetToFile(jwkSet); | |||
|
|
|||
| MockSecureSettings mockSecureSettings = | |||
There was a problem hiding this comment.
This fails because the truststore password is missing, but I can't figure out why. I'll check again my morning, but @tvernum if you have any ideas - I'm all ears
jkakavas
added a commit
that referenced
this pull request
May 22, 2019
rp.client_secret is a required secure setting. Make sure we fail with a SettingsException and a clear, actionable message when building the realm, if the setting is missing.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client_secret is a required secure setting. Make sure we fail with
a SettingsException and a clear, actionable message when building
the realm, if the setting is missing.