[Vis: Default editor] EUIficate string control

src/legacy/ui/public/agg_types/__tests__/buckets/date_histogram/_editor.js

@@ -21,6 +21,7 @@ import _ from 'lodash';
 import $ from 'jquery';
 import ngMock from 'ng_mock';
 import expect from 'expect.js';
+import sinon from 'sinon';
 import FixturesStubbedLogstashIndexPatternProvider from 'fixtures/stubbed_logstash_index_pattern';
 import { VisProvider } from '../../../../vis';
 import { intervalOptions } from '../../../buckets/_interval_options';
@@ -58,6 +59,10 @@ describe('editor', function () {
         ]
       });
 
+      const formCtrl = {
+        $addControl: sinon.fake()
+      };
+
       const $el = $('<vis-editor-agg-params agg="agg" ' +
         'index-pattern="agg.getIndexPattern()" ' +
         'group-name="groupName">' +
@@ -68,6 +73,7 @@ describe('editor', function () {
       $parentScope.groupName = 'buckets';
       $parentScope.vis = vis;
 
+      $el.data('$formController', formCtrl);
       $compile($el)($parentScope);
       $scope = $el.scope();
       $scope.$digest();

src/legacy/ui/public/agg_types/controls/string.tsx

@@ -41,7 +41,11 @@ function StringSelect({ agg = {}, aggParam = {}, onParamsChange }: StringSelectP
 
   return (
     <EuiFormRow label={aggParam.displayName || aggParam.name} className="form-group">
-      <EuiFieldText id={`visEditorStringInput${agg.id}${aggParam.name}`} onChange={onChange} />
+      <EuiFieldText
+        id={`visEditorStringInput${agg.id}${aggParam.name}`}
+        name={`visEditorStringInput${agg.id}${aggParam.name}`}
+        onChange={onChange}
+      />
     </EuiFormRow>
   );
 }

src/legacy/ui/public/vis/editors/default/__tests__/agg_params.js

@@ -21,6 +21,7 @@
 import angular from 'angular';
 import _ from 'lodash';
 import expect from 'expect.js';
+import sinon from 'sinon';
 import ngMock from 'ng_mock';
 import '../agg_params';
 import { VisProvider } from '../../..';
@@ -61,6 +62,10 @@ describe('Vis-Editor-Agg-Params plugin directive', function () {
     orderAggSchema = (new Schemas([config])).all[0];
     $parentScope.groupName = 'metrics';
 
+    const formCtrl = {
+      $addControl: sinon.fake()
+    };
+
     const state = {
       schema: orderAggSchema,
       type: 'count'
@@ -84,6 +89,8 @@ describe('Vis-Editor-Agg-Params plugin directive', function () {
       `<vis-editor-agg-params index-pattern="vis.indexPattern" agg="agg" group-name="groupName"></vis-editor-agg-params>`
     );
 
+    $elem.data('$formController', formCtrl);
+
     // compile the html
     compile($elem)($parentScope);
 

test/functional/page_objects/visualize_page.js

@@ -499,7 +499,7 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
     }
 
     async setCustomLabel(label, index = 1) {
-      const customLabel = await find.byCssSelector(`#visEditorStringInput${index}customLabel`);
+      const customLabel = await find.byCssSelector(`[name="visEditorStringInput${index}customLabel"]`);
       customLabel.type(label);
     }