[Vis: Default editor] EUIficate string control #32881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
maryia-lapata
commented
Mar 11, 2019
dmlemeshko
reviewed
Mar 11, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
maryia-lapata
added
the
Feature:Visualizations
This comment has been minimized.
This comment has been minimized.
cchaos
approved these changes
Mar 11, 2019
|
@cchaos yes, it's the auto-suggest from the browser.
|
29 tasks
Refactoring
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I added some changes according to @timroes's feedback. The screenshot wasn't changed. I also checked accessibility and pseudo locale, it works fine. |
maryia-lapata
requested review from
timroes and
dmlemeshko
and removed request for
timroes
💚 Build Succeeded |
dmlemeshko
approved these changes
Mar 14, 2019
timroes
approved these changes
Mar 14, 2019
There was a problem hiding this comment.
Tested and seems to work, and Code LGTM overall. Since I did some significant parts in this architecture I wonder, if maybe someone else from the team (cc @lukeelmers or @chrisdavies) could give this another review, before we're merging this.
💚 Build Succeeded |
lukeelmers
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
After a guided tour from @timroes, I think that all makes sense now...
Or at least, makes as much sense as the legacy angular world is ever going to make 😉
Thanks for digging into this -- LGTM!
| template: function ($el, attrs) { | ||
| if (attrs.editorComponent) { | ||
| // Why do we need the `ng-if` here? | ||
| // Short answer: Preventing black magic |
timroes
added
Team:Visualizations
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
maryia-lapata
added a commit
to maryia-lapata/kibana
that referenced
this pull request
Mar 18, 2019
* EUIficate string control * Fix tests * Update unit test * Add data-test-subj for input * Remove unused props * Refactoring * Add value prop to be able to discard changes on form * Refactoring * Set ng-model * Remove unnecessary check and specify model name * Set full width to be consistent with other controls from the form
maryia-lapata
added a commit
that referenced
this pull request
Mar 18, 2019
* EUIficate string control * Fix tests * Update unit test * Add data-test-subj for input * Remove unused props * Refactoring * Add value prop to be able to discard changes on form * Refactoring * Set ng-model * Remove unnecessary check and specify model name * Set full width to be consistent with other controls from the form
This was referenced Mar 18, 2019
timroes
added
the
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EUIfication of
stringcontrol for aggregation parameter.This control is used for
Custom label,ExcludeandIncludelabels onDatatab.Part of #30922
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Documentation was added for features that require explanation or tutorialsFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately