Fix: don't initialize workpad from WorkpadApp #32163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33ble
added
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
all the elements are laoded in the router, so loading the from the component just duplicates the work
w33ble
force-pushed
the
fix/duplicate-element-loading
branch
from
fa96139 to
d31af75
Compare
💚 Build Succeeded |
clintandrewhall
approved these changes
Feb 28, 2019
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Feb 28, 2019
Closes elastic#32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Feb 28, 2019
Closes elastic#32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Feb 28, 2019
Closes elastic#32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
clintandrewhall
added a commit
that referenced
this pull request
Feb 28, 2019
Closes #32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
clintandrewhall
added a commit
that referenced
this pull request
Feb 28, 2019
Closes #32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
clintandrewhall
added a commit
that referenced
this pull request
Feb 28, 2019
Closes #32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
monfera
pushed a commit
to monfera/kibana
that referenced
this pull request
Mar 8, 2019
Closes elastic#32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning* (cherry picked from commit acd762d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32161
All the elements are loaded in the router, so loading the from the component just duplicates the work.
This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now.
Stats
Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning