All elements are loaded twice on first load #32161
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Canvas
performance
PR sent
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
w33ble
added
bug
|
Pinging @elastic/kibana-canvas |
This was referenced Feb 27, 2019
clintandrewhall
pushed a commit
that referenced
this issue
Feb 28, 2019
Closes #32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this issue
Feb 28, 2019
Closes elastic#32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this issue
Feb 28, 2019
Closes elastic#32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this issue
Feb 28, 2019
Closes elastic#32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
clintandrewhall
added a commit
that referenced
this issue
Feb 28, 2019
Closes #32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
clintandrewhall
added a commit
that referenced
this issue
Feb 28, 2019
Closes #32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
clintandrewhall
added a commit
that referenced
this issue
Feb 28, 2019
Closes #32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning*
monfera
pushed a commit
to monfera/kibana
that referenced
this issue
Mar 8, 2019
Closes elastic#32161 All the elements are loaded in the router, so loading the from the component just duplicates the work. This is actually left-over code from before we had a router. Apparently I missed this lifecycle when adding the router, so it's been an issue in Canvas for quite some time now. ### Stats Workpad | Previous load time | PR load time -- | -- | -- Elastic{ON} Tour Dallas: Canvas v3 | 10 seconds | 7 seconds Kibana Canvas - Your data, your way. | 32 seconds | 18 seconds *Time from when the Canvas loading indicator goes away and the workpad app renders to when the loading indicator stops spinning* (cherry picked from commit acd762d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 6.5+
Describe the bug:
When loading a workpad, the action that loads all the elements in the workpad is fired twice, creating a bunch of needless extra work, thrashing from React as they all render twice, extra data processing... all things contributing to #24385.
Steps to reproduce:
The text was updated successfully, but these errors were encountered: