Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes noreferrer on explicit elastic.co domains #31008

Merged
merged 4 commits into from
Feb 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ exports[`props exportedFieldsUrl 1`] = `
fill={false}
href="exported_fields_url"
iconSide="left"
rel="noopener noreferrer"
rel="noopener"
target="_blank"
type="button"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ function IntroductionUI({ description, previewUrl, title, exportedFieldsUrl, ico
<EuiButton
href={exportedFieldsUrl}
target="_blank"
rel="noopener noreferrer"
rel="noopener"
>
<FormattedMessage id="kbn.home.tutorial.introduction.viewButtonLabel" defaultMessage="View exported fields"/>
</EuiButton>
Expand Down
16 changes: 8 additions & 8 deletions src/legacy/core_plugins/kibana/ui_setting_defaults.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function getUiSettingDefaults() {
'kbn.advancedSettings.query.queryStringOptionsText',
values: {
optionsLink:
'<a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html" target="_blank" rel="noopener noreferrer">' +
'<a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html" target="_blank" rel="noopener">' +
i18n.translate('kbn.advancedSettings.query.queryStringOptions.optionsLinkText', {
defaultMessage: 'Options',
}) +
Expand Down Expand Up @@ -94,7 +94,7 @@ export function getUiSettingDefaults() {
'kbn.advancedSettings.sortOptionsText',
values: {
optionsLink:
'<a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-sort.html" target="_blank" rel="noopener noreferrer">' +
'<a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-sort.html" target="_blank" rel="noopener">' +
i18n.translate('kbn.advancedSettings.sortOptions.optionsLinkText', {
defaultMessage: 'Options',
}) +
Expand Down Expand Up @@ -332,7 +332,7 @@ export function getUiSettingDefaults() {
setRequestReferenceSetting: '<strong>courier:setRequestPreference</strong>',
customSettingValue: '"custom"',
requestPreferenceLink:
'<a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-preference.html" target="_blank" rel="noopener noreferrer">' +
'<a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-preference.html" target="_blank" rel="noopener">' +
i18n.translate('kbn.advancedSettings.courier.customRequestPreference.requestPreferenceLinkText', {
defaultMessage: 'Request Preference',
}) +
Expand All @@ -354,15 +354,15 @@ export function getUiSettingDefaults() {
values: {
maxRequestsLink:
`<a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/search-multi-search.html"
target="_blank" rel="noopener noreferrer" >max_concurrent_shard_requests</a>`
target="_blank" rel="noopener" >max_concurrent_shard_requests</a>`
},
}),
category: ['search'],
},
'search:includeFrozen': {
name: 'Search in frozen indices',
description: `Will include <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/frozen-indices.html"
target="_blank" rel="noopener noreferrer">frozen indices</a> in results if enabled. Searching through frozen indices
target="_blank" rel="noopener">frozen indices</a> in results if enabled. Searching through frozen indices
might increase the search time.`,
value: false,
category: ['search'],
Expand Down Expand Up @@ -422,7 +422,7 @@ export function getUiSettingDefaults() {
values: {
cellDimensionsLink:
`<a href="http://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-geohashgrid-aggregation.html#_cell_dimensions_at_the_equator"
target="_blank" rel="noopener noreferrer">` +
target="_blank" rel="noopener">` +
i18n.translate('kbn.advancedSettings.visualization.tileMap.maxPrecision.cellDimensionsLinkText', {
defaultMessage: 'Explanation of cell dimensions',
}) +
Expand Down Expand Up @@ -819,7 +819,7 @@ export function getUiSettingDefaults() {
values: {
acceptedFormatsLink:
`<a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/common-options.html#date-math"
target="_blank" rel="noopener noreferrer">` +
target="_blank" rel="noopener">` +
i18n.translate('kbn.advancedSettings.timepicker.quickRanges.acceptedFormatsLinkText', {
defaultMessage: 'accepted formats',
}) +
Expand Down Expand Up @@ -869,7 +869,7 @@ export function getUiSettingDefaults() {
values: {
markdownLink:
`<a href="https://help.github.com/articles/basic-writing-and-formatting-syntax/"
target="_blank" rel="noopener noreferrer">` +
target="_blank" rel="noopener">` +
i18n.translate('kbn.advancedSettings.notifications.banner.markdownLinkText', {
defaultMessage: 'Markdown supported',
}) +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<a
class="rgmEMSLink pull-right"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
ng-href="{{editorState.params.emsHotLink}}"
target="_blank"
title="{{'regionMap.visParams.previewOnEMSLinkTitle' | i18n: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@
<a
href="https://www.elastic.co/guide/en/elasticsearch/reference/5.1/query-dsl-query-string-query.html#query-string-syntax"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
i18n-id="timelion.help.querying.luceneQueryLinkText"
i18n-default-message="Lucene query string"
i18n-description="Part of composite text
Expand Down Expand Up @@ -334,7 +334,7 @@
<a
href="https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-metrics.html"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
i18n-id="timelion.help.querying.countMetricAggregationLinkText"
i18n-default-message="Elasticsearch metric aggregation"
i18n-description="Part of composite text
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<li role="menuitem">
<a
target="_blank"
rel="noopener noreferrer"
rel="noopener"
href="https://www.elastic.co/guide/en/kibana/master/vega-graph.html"
i18n-id="vega.editor.vegaHelpLinkText"
i18n-default-message="Kibana Vega Help"
Expand Down
2 changes: 1 addition & 1 deletion src/legacy/ui/public/agg_types/controls/date_ranges.html
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
class="kuiLink"
documentation-href="date.dateMath"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
i18n-id="common.ui.aggTypes.dateRanges.acceptedDateFormatsLinkText"
i18n-default-message="Accepted date formats"
></a>
Expand Down
2 changes: 1 addition & 1 deletion src/legacy/ui/public/vis/editors/default/agg_select.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
href="{{aggHelpLink}}"
class="pull-right visEditorAggSelect__helpLink"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
i18n-id="common.ui.vis.editors.aggSelect.helpLinkLabel"
i18n-default-message="{aggTitle} help"
i18n-values="{ aggTitle: agg.type.title }"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ exports[`PropertiesTable AgentFeatureTipMessage component should render when doc
<EuiLink
color="primary"
href="mock-url"
rel="noopener noreferrer"
rel="noopener"
target="_blank"
type="button"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export function AgentFeatureTipMessage({
<TableInfo>
<EuiIconWithSpace type="iInCircle" />
{getAgentFeatureText(featureName)}{' '}
<EuiLink target="_blank" rel="noopener noreferrer" href={docsUrl}>
<EuiLink target="_blank" rel="noopener" href={docsUrl}>
{i18n.translate(
'xpack.apm.propertiesTable.agentFeature.learnMoreLinkLabel',
{ defaultMessage: 'Learn more in the documentation.' }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export class EditSettingsJson extends React.PureComponent {
<EuiLink
href={settingsDocumentationLink}
target="_blank"
rel="noopener noreferrer"
rel="noopener"
>
<FormattedMessage
id="xpack.idxMgmt.editSettingsJSON.settingsReferenceLinkText"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ interface InfraHeaderFeedbackLinkProps {

export const InfraHeaderFeedbackLink: React.SFC<InfraHeaderFeedbackLinkProps> = ({ url }) => (
<VerticallyCenteredHeaderSection side="right">
<EuiLink href={url} target="_blank" rel="noopener noreferrer">
<EuiLink href={url} target="_blank" rel="noopener">
<FormattedMessage
id="xpack.infra.headerFeedbackLink.feedbackText"
defaultMessage="Feedback"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`DocumentationHelpLink renders the link 1`] = `
<a
className="documentation-help-link"
href="http://fullUrl"
rel="noopener noreferrer"
rel="noopener"
target="_blank"
>
Label Text
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export function DocumentationHelpLink({ fullUrl, label }) {
return (
<a
href={fullUrl}
rel="noopener noreferrer"
rel="noopener"
target="_blank"
className="documentation-help-link"
>
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/searchprofiler/public/templates/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
i18n-id="xpack.searchProfiler.registerLicenseDescription"
i18n-default-message="Please {registerLicenseLink} to continue using the Search Profiler"
i18n-values="{
html_registerLicenseLink: '<a class=\'kuiLink\' href=\'https://www.elastic.co/subscriptions\' rel=\'noopener noreferrer\'>' + registerLicenseLinkLabel + '</a>',
html_registerLicenseLink: '<a class=\'kuiLink\' href=\'https://www.elastic.co/subscriptions\' rel=\'noopener\'>' + registerLicenseLinkLabel + '</a>',
}"
></p>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<a
href="{{ watchEditDetail.documentationLinks.watcher.putWatchApi }}"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
data-test-subj="lnkPutWatchApiDoc"
i18n-id="xpack.watcher.sections.watchEdit.detail.syntaxLinkLabel"
i18n-default-message="Syntax"
Expand Down