-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes noreferrer on explicit elastic.co domains #31008
Removes noreferrer on explicit elastic.co domains #31008
Conversation
💔 Build Failed |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML file edits LGTM
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
6.7 backport: #31326 |
7.0 backport: #31327 |
@ogupte @peteharverson @epixa could you please check this PR, looks like it wasn't backported into 7.x. Partially it will be fixed when we make a backport of #66040 into 7.x but we fix that only for one file |
Summary
This remove the
noreferrer
attribute on docsite links that are "known" elastic.co links. Here's the methodology I went through:noreferrer
in Kibana.snap
in them (snapshots).elastic.co
were whitelisted. I used my best judgement for the "implied" ones, so feel free to say "no" to them!I'm anticipating some test failures, and will follow up accordingly, but wanted to get this out for review prior to investing more time in stability.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.