Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes noreferrer on explicit elastic.co domains #31008

Merged
merged 4 commits into from
Feb 14, 2019
Merged

Removes noreferrer on explicit elastic.co domains #31008

merged 4 commits into from
Feb 14, 2019

Conversation

joelgriffith
Copy link
Contributor

@joelgriffith joelgriffith commented Feb 13, 2019

Summary

This remove the noreferrer attribute on docsite links that are "known" elastic.co links. Here's the methodology I went through:

  • Did a search of noreferrer in Kibana.
  • Filtered out anything with snap in them (snapshots).
  • Filtered out x-pack, but then added them in since it was easy enough.
  • Links that either had explicit references, or implied, to elastic.co were whitelisted. I used my best judgement for the "implied" ones, so feel free to say "no" to them!

I'm anticipating some test failures, and will follow up accordingly, but wanted to get this out for review prior to investing more time in stability.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML file edits LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joelgriffith joelgriffith merged commit cc6c31c into elastic:master Feb 14, 2019
@joelgriffith joelgriffith deleted the chore-remove-noreferrer-for-elasticco branch February 14, 2019 22:52
@joelgriffith
Copy link
Contributor Author

6.7 backport: #31326

@joelgriffith
Copy link
Contributor Author

7.0 backport: #31327

joelgriffith added a commit that referenced this pull request Feb 16, 2019
* Removes noreferrer on explicit elastic.co domains
joelgriffith added a commit that referenced this pull request Feb 16, 2019
* Removes noreferrer on explicit elastic.co domains
@alexwizp
Copy link
Contributor

alexwizp commented Jun 5, 2020

@ogupte @peteharverson @epixa could you please check this PR, looks like it wasn't backported into 7.x.
As a result all versions between 7.0 and 8 still have noreferrer.

https://github.com/elastic/kibana/blob/7.x/src/legacy/core_plugins/kibana/server/ui_setting_defaults.js#L256

Partially it will be fixed when we make a backport of #66040 into 7.x but we fix that only for one file ui_setting_defaults.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants