Enable query bar datepicker in core apps where appropriate #30171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bargs
added
Feature:Timepicker
|
Pinging @elastic/kibana-app |
Bargs
commented
Feb 6, 2019
src/legacy/core_plugins/kibana/public/visualize/editor/editor.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
Bargs
force-pushed
the
corePickerUpdates
branch
from
cd7a74d to
c31181d
Compare
💔 Build Failed |
Bargs
force-pushed
the
corePickerUpdates
branch
from
c31181d to
15334c4
Compare
💔 Build Failed |
lukasolson
reviewed
Feb 6, 2019
src/legacy/core_plugins/kibana/public/discover/controllers/discover.js
Outdated
Show resolved
Hide resolved
lukasolson
reviewed
Feb 6, 2019
src/legacy/core_plugins/kibana/public/visualize/editor/editor.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
|
@Bargs just FYI, JK has an open PR for the Uptime app and had created a service for using the new timepicker which was already in use there; I added comments to that PR about moving the timepicker method he had created out of x-pack and into the base test/functional/services |
Bargs
force-pushed
the
corePickerUpdates
branch
from
fc0728b to
04752cb
Compare
|
@LeeDr Nathan already built a Timepicker page object that works with the new time picker. Is this similar to what you're talking about? |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
jenkins test this |
💔 Build Failed |
|
jenkins, test this |
💔 Build Failed |
|
jenkins test this |
💔 Build Failed |
💔 Build Failed |
|
jenkins, test this |
💔 Build Failed |
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Feb 8, 2019
…0171) Updates discover, visualize, and dashboard to use the date picker added to the query bar in elastic#29130. There are still some areas where we use the top nav date picker, like Timelion and TSVB which don't have a query bar.
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Feb 8, 2019
…0171) Updates discover, visualize, and dashboard to use the date picker added to the query bar in elastic#29130. There are still some areas where we use the top nav date picker, like Timelion and TSVB which don't have a query bar.
lukeelmers
pushed a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 8, 2019
…0171) Updates discover, visualize, and dashboard to use the date picker added to the query bar in elastic#29130. There are still some areas where we use the top nav date picker, like Timelion and TSVB which don't have a query bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29674
Updates discover, visualize, and dashboard to use the date picker added to the query bar in #29130. There are still some areas where we use the top nav date picker, like Timelion and TSVB which don't have a query bar.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately