cleanup based on review feedback

elastic · Feb 7, 2019 · 04752cb · 04752cb
1 parent 0ee6136
commit 04752cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/src/legacy/core_plugins/kibana/public/discover/controllers/discover.js b/src/legacy/core_plugins/kibana/public/discover/controllers/discover.js
@@ -528,11 +528,7 @@ function discoverController(
         $scope.$listen(queryFilter, 'fetch', $scope.fetch);
 
         $scope.$watch('opts.timefield', function (timefield) {
-          if (!!timefield) {
-            $scope.enableTimeRangeSelector = true;
-          } else {
-            $scope.enableTimeRangeSelector = false;
-          }
+          $scope.enableTimeRangeSelector = !!timefield;
         });
 
         $scope.$watch('state.interval', function () {

diff --git a/src/legacy/core_plugins/kibana/public/visualize/editor/editor.js b/src/legacy/core_plugins/kibana/public/visualize/editor/editor.js
@@ -347,24 +347,18 @@ function VisEditor(
     ], function ([index, requiresTimePicker, requiresQueryBar]) {
       const showTimeFilter = Boolean((!index || index.timeFieldName) && requiresTimePicker);
 
-      if (showTimeFilter && requiresQueryBar) {
+      if (requiresQueryBar) {
         timefilter.disableTimeRangeSelector();
         timefilter.disableAutoRefreshSelector();
         $scope.enableQueryBarTimeRangeSelector = true;
-        $scope.showAutoRefreshOnlyInQueryBar = false;
+        $scope.showAutoRefreshOnlyInQueryBar = !showTimeFilter;
       }
       else if (showTimeFilter) {
         timefilter.enableTimeRangeSelector();
         timefilter.enableAutoRefreshSelector();
         $scope.enableQueryBarTimeRangeSelector = false;
         $scope.showAutoRefreshOnlyInQueryBar = false;
       }
-      else if (requiresQueryBar) {
-        timefilter.disableTimeRangeSelector();
-        timefilter.disableAutoRefreshSelector();
-        $scope.enableQueryBarTimeRangeSelector = true;
-        $scope.showAutoRefreshOnlyInQueryBar = true;
-      }
       else {
         timefilter.disableTimeRangeSelector();
         timefilter.enableAutoRefreshSelector();