Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude migrationVersion and references from getRootPropertiesObjects result #30081

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Exclude migrationVersion and references from getRootPropertiesObjects result #30081

merged 2 commits into from
Feb 5, 2019

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Feb 5, 2019

Fixes #29869

This PR modifies getRootPropertiesObjects function of mappings to exclude migrationVersion and references as they are not object types. The approach is to create a blacklist of properties to exclude.

@mikecote mikecote added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 labels Feb 5, 2019
@mikecote mikecote self-assigned this Feb 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mikecote
Copy link
Contributor Author

mikecote commented Feb 5, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote requested a review from legrego February 5, 2019 16:43
@mikecote mikecote added the review label Feb 5, 2019
legrego
legrego approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mikecote!

@mikecote mikecote merged commit f852812 into elastic:master Feb 5, 2019
@kobelb
Copy link
Contributor

kobelb commented Feb 5, 2019

Thanks @mikecote!!!

@mikecote mikecote added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

Assignees

@mikecote mikecote

Labels
non-issue Indicates to automation that a pull request should not appear in the release notes review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikecote @elasticmachine @kobelb @legrego