Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved object types are incorrectly determined #29869

Closed
legrego opened this issue Feb 1, 2019 · 1 comment
Closed

Saved object types are incorrectly determined #29869

legrego opened this issue Feb 1, 2019 · 1 comment
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0

Comments

@legrego
Copy link
Member

legrego commented Feb 1, 2019

Kibana version: 7.0

Saved Object References introduced a new root property (references) to the Kibana index mapping. This mapping happens to satisfy the existing criteria used to derive the full list of available saved object types. This full list of types is exposed on the saved objects service for consumers, and is used in a number of places.

The criteria for determining valid saved object types should be updated so that we do not include references, or anything else that we attach to the mapping which is not a saved object type.

We caught this due to a CI failure in our feature branch following a recent merge from master, so it might be worthwhile to also add a test to ensure this continues to work in the future.

/cc @kobelb

@legrego legrego added blocker Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 labels Feb 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@mikecote mikecote self-assigned this Feb 5, 2019
@epixa epixa added the bug Fixes for quality problems that affect the customer experience label Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0
Projects
None yet
Development

No branches or pull requests

4 participants