Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code] added symbol type to file types #28808

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

spacedragon
Copy link
Contributor

@spacedragon spacedragon commented Jan 16, 2019

Summary

https://github.com/elastic/code/issues/809
https://github.com/elastic/code/issues/741

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@spacedragon spacedragon requested a review from mw-ding January 16, 2019 03:44
@elasticmachine
Copy link
Contributor

💔 Build Failed

@spacedragon
Copy link
Contributor Author

elastic/eui#1439

Copy link
Contributor

@mw-ding mw-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. So this is also pending on Davey's EUI change right?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spacedragon
Copy link
Contributor Author

Yes

@mw-ding
Copy link
Contributor

mw-ding commented Jan 25, 2019

EUI just made a new release 6.7.0 a couple of hours ago https://github.com/elastic/eui/releases. It's now pending on updating the package version in kibana

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spacedragon spacedragon merged commit f25c9b9 into elastic:feature/merge-code Jan 25, 2019
@spacedragon spacedragon deleted the file_symbols branch January 25, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants