Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New symlink and submodule icons. #1439

Merged
merged 4 commits into from
Jan 16, 2019
Merged

New symlink and submodule icons. #1439

merged 4 commits into from
Jan 16, 2019

Conversation

daveyholler
Copy link
Contributor

@daveyholler daveyholler commented Jan 15, 2019 •
edited by zumwalt
Loading

Summary

Introducing new icons for 'symlink and submodule

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@daveyholler daveyholler requested review from cchaos and snide January 15, 2019 23:07
@cchaos
Copy link
Contributor

cchaos commented Jan 15, 2019

Code looks right, but the checklist item for dark mode is a must for icons (more a reminder).

@daveyholler
Copy link
Contributor Author

@cchaos I think I got a little carried away with my strikethroughs! 😄

cchaos
cchaos approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 👍

@spacedragon spacedragon mentioned this pull request Jan 16, 2019
Merged
1 task
@ryankeairns ryankeairns self-requested a review January 16, 2019 15:06
ryankeairns
ryankeairns approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice choice of icons, feel clear and familiar.

@cchaos
Copy link
Contributor

cchaos commented Jan 16, 2019

You'll now need to clean the test cache then update the tests again because the icon was updated after the test updates were run in order to get CI to pass.

$ yarn run test-unit -- --clearCache
$ yarn run test-unit -- -u

@daveyholler daveyholler merged commit 28b7ccb into elastic:master Jan 16, 2019
@snide snide mentioned this pull request Jan 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

@snide snide Awaiting requested review from snide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daveyholler @cchaos @ryankeairns