Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Translate missing labels in context #26970

Merged
merged 56 commits into from
Dec 14, 2018

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Dec 11, 2018

Translate missing labels

@Nox911 Nox911 requested a review from maryia-lapata December 13, 2018 07:38
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 requested a review from maryia-lapata December 13, 2018 09:13
@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Dec 13, 2018

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryia-lapata maryia-lapata requested a review from Bamieh December 13, 2018 12:09
@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Dec 14, 2018

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 removed the review label Dec 14, 2018
@Nox911 Nox911 merged commit 83d6764 into elastic:master Dec 14, 2018
@Nox911 Nox911 deleted the feature/translate-context branch December 14, 2018 09:43
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Dec 14, 2018
* Translate context and docs

* Fix issues

* Fix issues

* Fix issues
Nox911 pushed a commit that referenced this pull request Dec 14, 2018
* Translate context and docs

* Fix issues

* Fix issues

* Fix issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants