-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n] Translate additional part of Kibana #26461
Closed
tibmt
wants to merge
53
commits into
elastic:master
from
tibmt:feature/translations/kibanaAdditional
Closed
[i18n] Translate additional part of Kibana #26461
tibmt
wants to merge
53
commits into
elastic:master
from
tibmt:feature/translations/kibanaAdditional
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second merge
💔 Build Failed |
💔 Build Failed |
# Conflicts: # src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/tutorial.test.js.snap # src/legacy/core_plugins/kibana/public/home/components/tutorial/tutorial.js
💔 Build Failed |
maryia-lapata
suggested changes
Dec 10, 2018
src/legacy/core_plugins/kibana/public/home/components/tutorial/parameter_form.js
Outdated
Show resolved
Hide resolved
...a/public/management/sections/indices/create_index_pattern_wizard/components/header/header.js
Outdated
Show resolved
Hide resolved
...a/public/management/sections/indices/create_index_pattern_wizard/components/header/header.js
Outdated
Show resolved
Hide resolved
...ement/sections/indices/create_index_pattern_wizard/components/header/__jest__/header.test.js
Outdated
Show resolved
Hide resolved
..._plugins/kibana/public/management/sections/objects/components/objects_table/objects_table.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
maryia-lapata
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nox911
force-pushed
the
feature/translations/kibanaAdditional
branch
from
December 10, 2018 14:58
4a6d278
to
9ca0efa
Compare
Nox911
force-pushed
the
feature/translations/kibanaAdditional
branch
from
December 10, 2018 15:22
9ca0efa
to
00e96de
Compare
retest |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate additional part of Kibana