Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Translate additional part of Kibana #26461

Closed

Conversation

tibmt
Copy link
Contributor

@tibmt tibmt commented Nov 30, 2018

translate additional part of Kibana

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

# Conflicts:
#	src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/tutorial.test.js.snap
#	src/legacy/core_plugins/kibana/public/home/components/tutorial/tutorial.js
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nox911 Nox911 force-pushed the feature/translations/kibanaAdditional branch from 4a6d278 to 9ca0efa Compare December 10, 2018 14:58
@Nox911 Nox911 force-pushed the feature/translations/kibanaAdditional branch from 9ca0efa to 00e96de Compare December 10, 2018 15:22
@Nox911
Copy link
Contributor

Nox911 commented Dec 10, 2018

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911 Nox911 requested a review from maryia-lapata December 11, 2018 10:39
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 closed this Dec 13, 2018
@Nox911
Copy link
Contributor

Nox911 commented Dec 13, 2018

This PR has been separated into several PRs:
#26958
#26965
#26970
#26971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants