-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move legacy src/core_plugins
to src/legacy/core_plugins
.
#26412
Move legacy src/core_plugins
to src/legacy/core_plugins
.
#26412
Conversation
Pinging @elastic/kibana-platform |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: packages/kbn-i18n/README.md
has an example using core_plugins that should be updated. It's non-critical though since it's just an example. I didn't see any other references to core_plugins that needed to be updated.
Do not squash+merge. Git diffing works pretty well with renamed files, but it can get tripped up with certain changes when a commit both renames a file and makes changes to it, which can cause unnecessary git conflicts on existing PRs. Either use the rebase+merge or merge+with+commit option instead.
Good point, but these two options are marked as |
I just enabled rebase merge |
61f8ce3
to
49ccf96
Compare
Cleanly rebased on the latest master (with fixed CI) and waiting for green CI here to rebase + merge via GitHub. |
Previous CI run failed because of this (looks like intermittent CI connectivity issue):
|
💔 Build Failed |
💚 Build Succeeded |
6.x backport is currently blocked by backport of #22944 |
In this PR I move
src/core_plugins
tosrc/legacy/core_plugins
as per #12466 (comment).First commit just git moves core plugins to a new location and the rest commits are to fix paths within plugins and common code (easier to review commit by commit).
Initially I was planning to move plugin by plugin, but now I feel like it's safer to move it in one go to not break references between plugins and common code.