Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move management Jest tests from __test__ directories to __jest__ #22944

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Move management Jest tests from __test__ directories to __jest__ #22944

merged 1 commit into from
Sep 18, 2018

Conversation

cjcenizal
Copy link
Contributor

This is to differentiate them from Mocha tests.

@cjcenizal cjcenizal force-pushed the chore/management-test-dirs branch from a7ad634 to b87b551 Compare September 11, 2018 19:43
@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Copy link
Contributor Author

Retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Copy link
Contributor Author

Same X-Pack error in both failures:

           └- ✖ fail: "security app rbac  rbac all role can save a visualization"
           │      Error: retry.try timeout: Error: retry.try timeout: [POST http://localhost:9515/session/c84dc915496504431143753016f3ab7a/element / {"using":"css selector","value":"[data-test-subj~=\"visualizeSelectTypePage\"]"}] no such element: Unable to locate element: {"method":"css selector","selector":"[data-test-subj~="visualizeSelectTypePage"]"}

bmcconaghy
bmcconaghy approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as it goes green.

@bmcconaghy
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal cjcenizal force-pushed the chore/management-test-dirs branch from b87b551 to 48c407c Compare September 18, 2018 18:53
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal merged commit 3d2782c into elastic:master Sep 18, 2018
@cjcenizal cjcenizal deleted the chore/management-test-dirs branch September 18, 2018 20:36
@azasypkin azasypkin mentioned this pull request Dec 3, 2018
Merged
@cjcenizal cjcenizal added v6.6.0 and removed v6.5.0 labels Dec 3, 2018
@cjcenizal cjcenizal mentioned this pull request Dec 3, 2018
Merged
cjcenizal added a commit that referenced this pull request Dec 3, 2018
@cjcenizal
Move management Jest tests from __test__ directories to __jest__, to …
138cbc3 
…differentiate them from Mocha tests. (#22944) (#26557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcconaghy bmcconaghy bmcconaghy approved these changes

Assignees
No one assigned
Labels
backported chore v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjcenizal @elasticmachine @bmcconaghy @azasypkin